Skip to content

Commit 88d09a5

Browse files
authored
Merge pull request #314 from GeoNode/ISSUE_313
[Fixes #313] Bug in the NetworkRequesttask method which handles the timeout events
2 parents d63bcf5 + f7d15e3 commit 88d09a5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/qgis_geonode/tasks/network_task.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class NetworkRequestTask(qgis.core.QgsTask):
1616
requests_to_perform: typing.List[network.RequestToPerform]
1717
response_contents: typing.List[typing.Optional[network.ParsedNetworkReply]]
1818
_num_finished: int
19-
_pending_replies: typing.Dict[int, typing.Tuple[int, QtNetwork.QNetworkReply]]
19+
_pending_replies: typing.Dict[int, network.PendingReply]
2020

2121
_all_requests_finished = QtCore.pyqtSignal()
2222
task_done = QtCore.pyqtSignal(bool)
@@ -176,11 +176,11 @@ def _handle_request_timed_out(
176176
) -> None:
177177
log(f"Request with id: {request_params.requestId()} has timed out")
178178
try:
179-
index, qt_reply = self._pending_replies[request_params.requestId()]
179+
pending_reply = self._pending_replies[request_params.requestId()]
180180
except KeyError:
181181
pass # we are not managing this request, ignore
182182
else:
183-
self.response_contents[index] = None
183+
self.response_contents[pending_reply.index] = None
184184
self._num_finished += 1
185185
if self._num_finished >= len(self.requests_to_perform):
186186
self._all_requests_finished.emit()

0 commit comments

Comments
 (0)