This repository was archived by the owner on Feb 1, 2021. It is now read-only.
docker volume create & docker volume delete#1208
Merged
abronan merged 2 commits intodocker-archive:masterfrom Sep 23, 2015
vieux:volume_create_delete
Merged
docker volume create & docker volume delete#1208abronan merged 2 commits intodocker-archive:masterfrom vieux:volume_create_delete
abronan merged 2 commits intodocker-archive:masterfrom
vieux:volume_create_delete
Conversation
Contributor
Author
|
@lukemarsden can you try flocker with this PR and tell me how it goes ? Thanks. |
vieux
added
status/1-design-review
status/2-code-review
and removed
status/0-triage
labels
Contributor
|
Hey @vieux, sure, we'll take a look. |
Signed-off-by: Victor Vieux <vieux@docker.com>
Signed-off-by: Victor Vieux <vieux@docker.com>
Closed
|
LGTM |
Contributor
Author
|
@lukemarsden any news on this PR ? Thank you |
|
@vieux will this PR support opts as well? |
Contributor
Author
|
yes, it includes |
Contributor
|
LGTM. Let's merge this now, if there is any feedback on this one feel free to comment on this PR or in a separate issue. |
abronan
added a commit
that referenced
this pull request
Sep 23, 2015
docker volume create & docker volume delete
Contributor
|
Sorry for the delay, @vieux - the person I asked to take a look at this went on vacation. I'm trying to organize a followup now. We would very much like this to work with Flocker and it's not necessarily obvious that my reasoning in #1189 (comment) will hold for the current incarnation of the Flocker Docker plugin, so this is high priority for us. |
|
Any design document for this? |
ChristianKniep
pushed a commit
to ChristianKniep/swarm
that referenced
this pull request
Jul 27, 2017
docker volume create & docker volume delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.