example
#184984
reproduction steps
- X authors PR
- Y reviews PR with request changes
- X makes changes
- Y approves changes
- X fixes merge conflicts (which invalidates all previous approvals)
- Z approves changes
In this state the PR just has one review that is an approval, but it will fail to merge the PR with the following message:
autosubmit label was removed for flutter/flutter/184984, because This PR has not met approval requirements for merging. Changes were requested by {Y}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
- Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
observed behavior
The PR is blocked from merging, despite the PR having only one active review which is approval.
expected behavior
Since Y's last review was approval, and the PR has an active review from Z, it should be merged.
example
#184984
reproduction steps
In this state the PR just has one review that is an approval, but it will fail to merge the PR with the following message:
observed behavior
The PR is blocked from merging, despite the PR having only one active review which is approval.
expected behavior
Since Y's last review was approval, and the PR has an active review from Z, it should be merged.