Skip to content

update minimum go version #3369

@shinenelson

Description

@shinenelson

I was attempting to compile go from source using the latest HEAD. But I could not get the compilation to complete because it required a minimum version higher than the one specified in go.mod.

hub/go.mod

Line 3 in 5c547ed

go 1.11

go mod specifies go1.11 as the version that the source builds on, but while attempting a build, it fails. I was attempting a build using go1.14 which was higher than the minimum version. Using go1.17 resolved the error and completed the build successfully.

Command attempted:
make bin/hub

What happened:

/home/shine/go/pkg/mod/golang.org/x/[email protected]/unix/syscall.go:83:16: undefined: unsafe.Slice
/home/shine/go/pkg/mod/golang.org/x/[email protected]/unix/syscall_linux.go:2271:9: undefined: unsafe.Slice
/home/shine/go/pkg/mod/golang.org/x/[email protected]/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
/home/shine/go/pkg/mod/golang.org/x/[email protected]/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
note: module requires Go 1.17
make: *** [Makefile:51: bin/hub] Error 2

Steps to Reproduce
use any go version < go1.17.

  1. git clone https://github.com/mislav/hub
  2. make bin/hub

I can create a pull request if this is a valid bug and the version in go.mod needs updating.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions