Merge pull request #109 from rubygems/remove-downloads-method

Remove `Gems.downloads` since the API endpoint has been deprecated

Author: hsbt

README.md

@@ -63,17 +63,6 @@ Gems.total_downloads 'rails_admin', '0.0.1'
 # Returns an array containing the top 50 downloaded gem versions of all time.
 Gems.most_downloaded
 
-# Return the total number of downloads by day for rails_admin 0.0.1.
-# (Defaults to the latest version if no version is specified.)
-Gems.downloads 'rails_admin', '0.0.1'
-
-# Return the number of downloads by day for coulda 0.6.3 for the past 90 days.
-# (Defaults to the latest version if no version is specified.)
-Gems.downloads 'coulda', '0.6.3', Date.today - 90, Date.today
-
-# Return the number of downloads by day for coulda 0.6.3 for the past year.
-Gems.downloads 'coulda', '0.6.3', Date.today - 365, Date.today
-
 # View all owners of a gem that you own.
 Gems.owners 'gemcutter'
 

lib/gems/v1/client.rb

@@ -154,21 +154,6 @@ def most_downloaded
         JSON.parse(response)['gems']
       end
 
-      # Returns the number of downloads by day for a particular gem version
-      #
-      # @authenticated false
-      # @param gem_name [String] The name of a gem.
-      # @param gem_version [String] The version of a gem.
-      # @param from [Date] Search start date.
-      # @param to [Date] Search end date.
-      # @return [Hash]
-      # @example
-      #   Gems.downloads 'coulda', '0.6.3', Date.today - 30, Date.today
-      def downloads(gem_name, gem_version = nil, from = nil, to = Date.today)
-        gem_version ||= info(gem_name)['version']
-        response = from ? get("/api/v1/versions/#{gem_name}-#{gem_version}/downloads/search.json", :from => from.to_s, :to => to.to_s) : get("/api/v1/versions/#{gem_name}-#{gem_version}/downloads.json")
-        JSON.parse(response)
-      end
 
       # View all owners of a gem that you own
       #

spec/fixtures/downloads.json

@@ -262,57 +262,6 @@
     end
   end
 
-  describe '#downloads' do
-    context 'with no dates or version specified' do
-      before do
-        stub_get('/api/v1/gems/coulda.json').
-          to_return(:body => fixture('rails.json'))
-        stub_get('/api/v1/versions/coulda-3.0.9/downloads.json').
-          to_return(:body => fixture('downloads.json'))
-      end
-      it 'returns the number of downloads by day for a particular gem version' do
-        downloads = Gems.downloads 'coulda'
-        expect(a_get('/api/v1/gems/coulda.json')).to have_been_made
-        expect(a_get('/api/v1/versions/coulda-3.0.9/downloads.json')).to have_been_made
-        expect(downloads['2011-06-22']).to eq 8
-      end
-    end
-    context 'with no dates specified' do
-      before do
-        stub_get('/api/v1/versions/coulda-0.6.3/downloads.json').
-          to_return(:body => fixture('downloads.json'))
-      end
-      it 'returns the number of downloads by day for a particular gem version' do
-        downloads = Gems.downloads 'coulda', '0.6.3'
-        expect(a_get('/api/v1/versions/coulda-0.6.3/downloads.json')).to have_been_made
-        expect(downloads['2011-06-22']).to eq 8
-      end
-    end
-    context 'with from date specified' do
-      before do
-        stub_get('/api/v1/versions/coulda-0.6.3/downloads/search.json').
-          with(:query => {'from' => '2011-01-01', 'to' => Date.today.to_s}).
-          to_return(:body => fixture('downloads.json'))
-      end
-      it 'returns the number of downloads by day for a particular gem version' do
-        downloads = Gems.downloads 'coulda', '0.6.3', Date.parse('2011-01-01')
-        expect(a_get('/api/v1/versions/coulda-0.6.3/downloads/search.json').with(:query => {'from' => '2011-01-01', 'to' => Date.today.to_s})).to have_been_made
-        expect(downloads['2011-06-22']).to eq 8
-      end
-    end
-    context 'with from and to dates specified' do
-      before do
-        stub_get('/api/v1/versions/coulda-0.6.3/downloads/search.json').
-          with(:query => {'from' => '2011-01-01', 'to' => '2011-06-28'}).
-          to_return(:body => fixture('downloads.json'))
-      end
-      it 'returns the number of downloads by day for a particular gem version' do
-        downloads = Gems.downloads 'coulda', '0.6.3', Date.parse('2011-01-01'), Date.parse('2011-06-28')
-        expect(a_get('/api/v1/versions/coulda-0.6.3/downloads/search.json').with(:query => {'from' => '2011-01-01', 'to' => '2011-06-28'})).to have_been_made
-        expect(downloads['2011-06-22']).to eq 8
-      end
-    end
-  end
 
   describe '#owners' do
     before do