Minor tweaks

Author: sindresorhus

.github/workflows/claude-code-review.yml

@@ -40,6 +40,8 @@ jobs:
 
             Use `gh pr comment` with your Bash tool to leave your review as a comment on the PR.
 
+            Be succinct. Double-check everything.
+
           # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
           # or https://docs.claude.com/en/docs/claude-code/sdk#command-line for available options
           claude_args: '--allowed-tools "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"'

.github/workflows/main.yml

@@ -20,8 +20,8 @@ jobs:
           - 22
           - 20
     steps:
-      - uses: actions/checkout@v5
-      - uses: actions/setup-node@v5
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
         with:
           node-version: ${{ matrix.node-version }}
       - run: npm install
@@ -34,10 +34,11 @@ jobs:
       matrix:
         typescript-version:
           - 'latest'
+          - '~6.0.0'
           - '~5.9.0'
     steps:
-      - uses: actions/checkout@v5
-      - uses: actions/setup-node@v5
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
         with:
           node-version: 24
       - run: npm install

.github/workflows/ts-canary.yml

@@ -15,8 +15,8 @@ jobs:
           - next
           - latest
     steps:
-      - uses: actions/checkout@v5
-      - uses: actions/setup-node@v5
+      - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
         with:
           node-version: lts/*
       - run: npm install

source/delimiter-case.d.ts

@@ -38,6 +38,7 @@ import type {DelimiterCase} from 'type-fest';
 
 const someVariable: DelimiterCase<'fooBar', '#'> = 'foo#bar';
 const someVariableNoSplitOnNumbers: DelimiterCase<'p2pNetwork', '#', {splitOnNumbers: false}> = 'p2p#network';
+const someVariableWithPunctuation: DelimiterCase<'div.card::after', '#', {splitOnPunctuation: true}> = 'div#card#after';
 
 // Advanced
 

source/delimiter-cased-properties-deep.d.ts

@@ -51,6 +51,13 @@ const splitOnNumbers: DelimiterCasedPropertiesDeep<{line1: {line2: [{line3: stri
 		],
 	},
 };
+
+const splitOnPunctuation: DelimiterCasedPropertiesDeep<{'user@info': {'user::id': number; 'user::name': string}}, '-', {splitOnPunctuation: true}> = {
+	'user-info': {
+		'user-id': 1,
+		'user-name': 'Tom',
+	},
+};
 ```
 
 @category Change case

source/delimiter-cased-properties.d.ts

@@ -27,6 +27,10 @@ const result: DelimiterCasedProperties<User, '-'> = {
 const splitOnNumbers: DelimiterCasedProperties<{line1: string}, '-', {splitOnNumbers: true}> = {
 	'line-1': 'string',
 };
+
+const splitOnPunctuation: DelimiterCasedProperties<{'foo::bar': string}, '-', {splitOnPunctuation: true}> = {
+	'foo-bar': 'string',
+};
 ```
 
 @category Change case

source/screaming-snake-case.d.ts

@@ -14,6 +14,7 @@ import type {ScreamingSnakeCase} from 'type-fest';
 
 const someVariable: ScreamingSnakeCase<'fooBar'> = 'FOO_BAR';
 const someVariableNoSplitOnNumbers: ScreamingSnakeCase<'p2pNetwork', {splitOnNumbers: false}> = 'P2P_NETWORK';
+const someVariableWithPunctuation: ScreamingSnakeCase<'div.card::after', {splitOnPunctuation: true}> = 'DIV_CARD_AFTER';
 
 ```
 

source/words.d.ts

@@ -97,7 +97,7 @@ type Words6 = Words<'hello:world', {splitOnPunctuation: true}>;
 type Words7 = Words<'hello:world', {splitOnPunctuation: false}>;
 //=> ['hello', ':world']
 
-type Words8 = Words<'hello:world', {splitOnPunctuation: true}>;
+type Words8 = Words<'hello::world', {splitOnPunctuation: true}>;
 //=> ['hello', 'world']
 ```
 

test-d/delimiter-case.ts

@@ -115,21 +115,39 @@ expectType<`foo${string}`>(stringPart);
 declare const withPunctuation: DelimiterCase<'onDialog:close', '#'>;
 expectType<'on#dialog:close'>(withPunctuation);
 
+declare const withPunctuationAndSplit: DelimiterCase<'onDialog:close', '#', {splitOnPunctuation: true}>;
+expectType<'on#dialog#close'>(withPunctuationAndSplit);
+
 declare const withPunctuation2: DelimiterCase<'foo-bar>>baz', '#'>;
 expectType<'foo#bar>>baz'>(withPunctuation2);
 
+declare const withPunctuationAndSplit2: DelimiterCase<'foo-bar>>baz', '#', {splitOnPunctuation: true}>;
+expectType<'foo#bar#baz'>(withPunctuationAndSplit2);
+
 declare const withPunctuation3: DelimiterCase<'card::after', '#'>;
 expectType<'card::after'>(withPunctuation3);
 
+declare const withPunctuationAndSplit3: DelimiterCase<'card::after', '#', {splitOnPunctuation: true}>;
+expectType<'card#after'>(withPunctuationAndSplit3);
+
 declare const withPunctuation4: DelimiterCase<'div.card::after', '#'>;
 expectType<'div.card::after'>(withPunctuation4);
 
+declare const withPunctuationAndSplit4: DelimiterCase<'div.card::after', '#', {splitOnPunctuation: true}>;
+expectType<'div#card#after'>(withPunctuationAndSplit4);
+
 declare const withPunctuationAndNumber: DelimiterCase<'foo-bar::01', '#'>;
 expectType<'foo#bar::01'>(withPunctuationAndNumber);
 
 declare const withPunctuationAndNumber2: DelimiterCase<'foo-bar::01', '#', {splitOnNumbers: true}>;
 expectType<'foo#bar::#01'>(withPunctuationAndNumber2);
 
+declare const withPunctuationSplitAndNumber: DelimiterCase<'foo-bar::01', '#', {splitOnPunctuation: true}>;
+expectType<'foo#bar#01'>(withPunctuationSplitAndNumber);
+
+declare const withPunctuationSplitAndNumberSplit: DelimiterCase<'foo-bar::01', '#', {splitOnPunctuation: true; splitOnNumbers: true}>;
+expectType<'foo#bar#01'>(withPunctuationSplitAndNumberSplit);
+
 // Verifying example
 type OddCasedProperties<T> = {
 	[K in keyof T as DelimiterCase<K, '#'>]: T[K];

test-d/delimiter-cased-properties-deep.ts

@@ -13,6 +13,15 @@ expectType<Set<{'foo-bar': string}>>(bar);
 declare const withOptions: DelimiterCasedPropertiesDeep<Set<{helloWorld: {p2p: Array<{addressLine1: string}>}}>, '.', {splitOnNumbers: true}>;
 expectType<Set<{'hello.world': {'p.2.p': Array<{'address.line.1': string}>}}>>(withOptions);
 
+declare const withPunctuation: DelimiterCasedPropertiesDeep<{'hello@World1': {'foo::Bar': string}}, '.'>;
+expectType<{'hello@.world1': {'foo::.bar': string}}>(withPunctuation);
+
+declare const withPunctuationSplit: DelimiterCasedPropertiesDeep<{'hello@World1': {'foo::Bar': string}}, '.', {splitOnPunctuation: true}>;
+expectType<{'hello.world1': {'foo.bar': string}}>(withPunctuationSplit);
+
+declare const withPunctuationSplitAndNumbers: DelimiterCasedPropertiesDeep<{'hello@World1': {'foo::Bar1': string}}, '.', {splitOnPunctuation: true; splitOnNumbers: true}>;
+expectType<{'hello.world.1': {'foo.bar.1': string}}>(withPunctuationSplitAndNumbers);
+
 // Verify example
 type User = {
 	userId: number;
@@ -26,6 +35,18 @@ type UserWithFriends = {
 	userFriends: User[];
 };
 
+type UserPunctuated = {
+	'user::id': number;
+	'user::name': string;
+	date: Date;
+	'reg::exp': RegExp;
+};
+
+type UserWithFriendsPunctuated = {
+	'user@info': UserPunctuated;
+	'user#friends': UserPunctuated[];
+};
+
 const result: DelimiterCasedPropertiesDeep<UserWithFriends, '-'> = {
 	'user-info': {
 		'user-id': 1,
@@ -49,6 +70,7 @@ const result: DelimiterCasedPropertiesDeep<UserWithFriends, '-'> = {
 	],
 };
 expectType<DelimiterCasedPropertiesDeep<UserWithFriends, '-'>>(result);
+expectType<DelimiterCasedPropertiesDeep<UserWithFriendsPunctuated, '-', {splitOnPunctuation: true}>>(result);
 
 // Test object key properties
 declare const key: DelimiterCasedPropertiesDeep<{readonly userId?: number}, '-'>;
@@ -89,3 +111,6 @@ expectType<{'foo_bar': {'bar_baz': unknown}; biz: unknown}>({} as DelimiterCased
 
 expectType<{'foo-bar': any}>({} as DelimiterCasedPropertiesDeep<{fooBar: any}, '-'>);
 expectType<{'foo_bar': {'bar_baz': any}; biz: any}>({} as DelimiterCasedPropertiesDeep<{fooBar: {barBaz: any}; biz: any}, '_'>);
+
+expectType<{'foo-bar': unknown}>({} as DelimiterCasedPropertiesDeep<{'foo::bar': unknown}, '-', {splitOnPunctuation: true}>);
+expectType<{'foo_bar': {'bar_baz': unknown}; biz: unknown}>({} as DelimiterCasedPropertiesDeep<{'foo::bar': {'bar@baz': unknown}; biz: unknown}, '_', {splitOnPunctuation: true}>);