Skip to content

Commit 95e00b5

Browse files
authored
Merge pull request #66 from thexai/GoogleTest-1.13.0
Bump GoogleTest to 1.17.0
2 parents b9790bf + 98d9e19 commit 95e00b5

File tree

2 files changed

+30
-4
lines changed

2 files changed

+30
-4
lines changed

CMakeLists.txt

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -542,15 +542,18 @@ add_dependency_project_package(shairplay 096b61a)
542542
endif()
543543

544544
ExternalProject_Add(GoogleTest
545-
GIT_REPOSITORY https://github.com/Google/GoogleTest
546-
GIT_TAG 703bd9caab50b139428cea1aaff9974ebee5742e
547-
GIT_SHALLOW ON
545+
DOWNLOAD_DIR ${CMAKE_SOURCE_DIR}/downloads
546+
URL https://github.com/google/googletest/releases/download/v1.17.0/googletest-1.17.0.tar.gz
547+
URL_HASH SHA256=65fab701d9829d38cb77c14acdc431d2108bfdbf8979e40eb8ae567edf10b27c
548+
PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_SOURCE_DIR}/patches/$(TargetName).diff
548549
CMAKE_ARGS
549550
${ADDITIONAL_ARGS}
550551
-Dgtest_force_shared_crt:BOOL=ON
552+
-DBUILD_GMOCK:BOOL=OFF
553+
-DCMAKE_DEBUG_POSTFIX=d
551554
-DCMAKE_INSTALL_PREFIX:PATH=${INSTALL_PREFIX}
552555
)
553-
add_dependency_project_package(GoogleTest 1.10.0)
556+
add_dependency_project_package(GoogleTest 1.17.0)
554557

555558
add_custom_target(DependenciesRequired
556559
DEPENDS

patches/GoogleTest.diff

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
diff --git a/googletest/cmake/internal_utils.cmake b/googletest/cmake/internal_utils.cmake
2+
index 7ca256a7..40631be1 100644
3+
--- a/googletest/cmake/internal_utils.cmake
4+
+++ b/googletest/cmake/internal_utils.cmake
5+
@@ -75,7 +75,7 @@ macro(config_compiler_and_linker)
6+
# TODO(vladl@google.com): Add -RTCs and -RTCu to debug builds.
7+
set(cxx_base_flags "-GS -W4 -WX -wd4251 -wd4275 -nologo -J")
8+
set(cxx_base_flags "${cxx_base_flags} -D_UNICODE -DUNICODE -DWIN32 -D_WIN32")
9+
- set(cxx_base_flags "${cxx_base_flags} -DSTRICT -DWIN32_LEAN_AND_MEAN")
10+
+ set(cxx_base_flags "${cxx_base_flags} -DSTRICT -DWIN32_LEAN_AND_MEAN -D_USE_STD_VECTOR_ALGORITHMS=0")
11+
set(cxx_exception_flags "-EHsc -D_HAS_EXCEPTIONS=1")
12+
set(cxx_no_exception_flags "-EHs-c- -D_HAS_EXCEPTIONS=0")
13+
set(cxx_no_rtti_flags "-GR-")
14+
@@ -173,8 +173,7 @@ function(cxx_library_with_type name type cxx_flags)
15+
RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin"
16+
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib"
17+
ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib"
18+
- PDB_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin"
19+
- COMPILE_PDB_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")
20+
+ PDB_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")
21+
# Make PDBs match library name.
22+
get_target_property(pdb_debug_postfix ${name} DEBUG_POSTFIX)
23+
set_target_properties(${name}

0 commit comments

Comments
 (0)