OPSEXP-3205 Handle extra amps in upgrade checks (#1223)

Author: pmacius

.secrets.baseline

@@ -159,7 +159,7 @@
         "filename": "playbooks/acs.yml",
         "hashed_secret": "0ca8f28152882e5edb182fc3f7d4ae10a5b10dc5",
         "is_verified": false,
-        "line_number": 628
+        "line_number": 639
       }
     ],
     "roles/activemq/molecule/default/tests/test_activemq.py": [
@@ -203,5 +203,5 @@
       }
     ]
   },
-  "generated_at": "2025-05-23T12:57:23Z"
+  "generated_at": "2025-07-03T14:21:08Z"
 }

docs/deployment-guide.md

@@ -687,12 +687,17 @@ in the commented example below:
 ```yml
 acs_play_repository_extra_amp_downloads: []
   # - url: "https://your.repo.com/path/to/your/artifacts/your-amp.amp"
+  #   name: your-amp # optional, name is used for upgrade checks
+  #   version: 1.0.0 # optional, version is used for upgrade checks
   #   checksum: "sha1:2aae6c35c94fcfb415dbe95f408b9ce91ee846ed"
   #   dest: "{{ repository_content_folder }}/<amps_repo|amps_share>/your-amp.amp"
   #   url_username: your_username_to_repo
   #   url_password: your_password_to_repo
 ```
 
+> :warning: `name` and `version` are not mandatory but highly recommended to
+> use, they are used in the upgrade checks to avoid unsupported upgrades.
+
 ### JVM Options
 
 Each Java based service deployed by the playbook is configured with some default settings, including memory settings.

playbooks/acs.yml

@@ -402,6 +402,17 @@
           }) }}
       when: acs_is_enterprise
 
+    - name: Add extra amps if provided and required properties are set
+      ansible.builtin.set_fact:
+        amps: >-
+          {{ amps | combine({
+            item.name: {
+              'version': item.version
+            }
+          }) }}
+      loop: "{{ acs_play_repository_extra_amp_downloads | default([]) }}"
+      when: item.version is defined and item.name is defined
+
     - name: Update installation status file with ACS
       become: true
       vars:

playbooks/group_vars/repository.yml

@@ -40,6 +40,8 @@ acs_play_repository_amp_aos_module_archive_url: "{{ acs_play_repository_amp_aos_
 # additional list of amp downloads
 acs_play_repository_extra_amp_downloads: []
   # - url: "https://your.repo.com/path/to/your/artifacts/your-amp.amp"
+  #   name: your-amp # optional, name is used for upgrade checks
+  #   version: 1.0.0 # optional, version is used for upgrade checks
   #   checksum: "sha1:2aae6c35c94fcfb415dbe95f408b9ce91ee846ed"
   #   dest: "{{ repository_content_folder }}/<amps_repo|amps_share>/your-amp.amp"
   #   url_username: your_username_to_repo

playbooks/prerun-upgrade-checks.yml

@@ -70,6 +70,25 @@
               }) }}
           when: acs_play_repository_acs_edition == 'Enterprise'
 
+        - name: Add extra amps if provided and required properties are set
+          vars:
+            # Vars commonly used in the list that are not accessible by this
+            # playbook as they are not defined in the repository group_vars
+            # file. Nexus credentials are comming from common role which
+            # eventually will be moved to global secrets.
+            repository_content_folder: ""
+            nexus_user: ""
+            nexus_password: ""
+          ansible.builtin.set_fact:
+            amps: >-
+              {{ amps | combine({
+                item.name: {
+                  'version': item.version
+                }
+              }) }}
+          loop: "{{ acs_play_repository_extra_amp_downloads | default([]) }}"
+          when: item.name is defined and item.version is defined
+
         - name: Fail on unsupported AMPS upgrades
           ansible.builtin.fail:
           when: |