equal-values: fix false positive with any

When variables are both any, we should not report.

Author: ccoVeille

analyzer/testdata/src/checkers-default/equal-values/equal_values_test.go

@@ -43,6 +43,12 @@ func TestEqualValuesChecker(t *testing.T) {
 		b           []byte
 		f           func() bool
 	)
+
+	var (
+		anyInt   any = 42
+		anyFloat any = 42.0
+	)
+
 	tlsConf := new(tls.Config)
 
 	// Invalid.
@@ -127,6 +133,8 @@ func TestEqualValuesChecker(t *testing.T) {
 		assert.EqualValuesf(t, 2048, mm["Etype"], "msg with args %d %s", 42, "42")
 		assert.EqualValues(t, req, dto)
 		assert.EqualValuesf(t, req, dto, "msg with args %d %s", 42, "42")
+		assert.EqualValues(t, anyInt, anyFloat)
+		assert.EqualValuesf(t, anyInt, anyFloat, "msg with args %d %s", 42, "42")
 		assert.EqualValues(t, req, reqWithTags)
 		assert.EqualValuesf(t, req, reqWithTags, "msg with args %d %s", 42, "42")
 		assert.EqualValues(t, S{"1"}, []string{"1"})

analyzer/testdata/src/checkers-default/equal-values/equal_values_test.go.golden

@@ -43,9 +43,17 @@ func (checker EqualValues) Check(pass *analysis.Pass, call *CallMeta) *analysis.
 	}
 
 	ft, st := pass.TypesInfo.TypeOf(first), pass.TypesInfo.TypeOf(second)
-	if types.Identical(ft, st) {
-		proposed := strings.TrimSuffix(assrn, "Values")
-		return newUseFunctionDiagnostic(checker.Name(), call, proposed)
+	if !types.Identical(ft, st) {
+		return nil
 	}
-	return nil
+
+	switch ft.String() {
+	case "any", "interface {}":
+		// EqualValues is ok here.
+		// Equal would check their types and would fail
+		return nil
+	}
+
+	proposed := strings.TrimSuffix(assrn, "Values")
+	return newUseFunctionDiagnostic(checker.Name(), call, proposed)
 }

internal/checkers/equal_values.go

@@ -67,6 +67,7 @@ func (g EqualValuesTestsGenerator) TemplateData() any {
 
 			{Fn: "EqualValues", Argsf: `2048, mm["Etype"]`},
 			{Fn: "EqualValues", Argsf: `req, dto`},
+			{Fn: "EqualValues", Argsf: `anyInt, anyFloat`},
 			{Fn: "EqualValues", Argsf: `req, reqWithTags`},
 			{Fn: "EqualValues", Argsf: `S{"1"}, []string{"1"}`},
 			{Fn: "EqualValues", Argsf: `f, (func())(nil)`},
@@ -131,6 +132,12 @@ func {{ .CheckerName.AsTestName }}(t *testing.T) {
 		b   []byte
 		f   func() bool
 	)
+
+	var (
+		anyInt any = 42
+		anyFloat any = 42.0
+	)
+
 	tlsConf := new(tls.Config)
 
 	// Invalid.