Remove post-install verification check

The scenario where installCli() silently fails is very unlikely.
Simplify by setting the flag unconditionally after install, consistent
with the macOS approach.

Author: ivan-ottinger

apps/studio/src/modules/cli/lib/tests/windows-installation-manager.test.ts

@@ -177,24 +177,6 @@ describe.skipIf( isNonWindows )( 'WindowsCliInstallationManager', () => {
 			expect( mockRegistrySet ).not.toHaveBeenCalled();
 			expect( mockUpdateAppdata ).not.toHaveBeenCalled();
 		} );
-
-		it( 'does not set cliAutoInstalled flag when install fails', async () => {
-			// Registry PATH doesn't contain studio bin dir
-			mockRegistryGet.mockImplementation(
-				( _key: string, cb: ( err: Error | null, item?: { value: string } ) => void ) =>
-					cb( null, { value: 'C:\\Windows\\system32' } )
-			);
-			mockRegistrySet.mockImplementation(
-				( _key: string, _type: string, _value: string, cb: ( err: Error | null ) => void ) =>
-					cb( null )
-			);
-			// Simulate failure: bin dir doesn't exist after install
-			mockExistsSync.mockReturnValue( false );
-
-			await manager.autoInstallIfNeeded();
-
-			expect( mockUpdateAppdata ).not.toHaveBeenCalled();
-		} );
 	} );
 } );
 

apps/studio/src/modules/cli/lib/windows-installation-manager.ts

@@ -48,10 +48,7 @@ export class WindowsCliInstallationManager implements StudioCliInstallationManag
 		}
 
 		await this.installCli();
-
-		if ( await this.isCliInstalled() ) {
-			await updateAppdata( { cliAutoInstalled: true } );
-		}
+		await updateAppdata( { cliAutoInstalled: true } );
 	}
 
 	async installCliWithConfirmation(): Promise< void > {