fix: pass along coinbase (#13560)

Let's see if this passes tests

Fix #13643

Co-authored-by: Lasse Herskind <[email protected]>

Author: alexghr

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/block_root/components/block_root_rollup_output_composer.nr

@@ -121,12 +121,10 @@ impl BlockRootRollupOutputComposer {
         };
 
         let mut fees = [FeeRecipient::empty(); AZTEC_MAX_EPOCH_DURATION];
-        if accumulated_fees != 0 {
-            fees[0] = FeeRecipient {
-                recipient: constants.global_variables.coinbase,
-                value: accumulated_fees,
-            };
-        }
+        fees[0] = FeeRecipient {
+            recipient: constants.global_variables.coinbase,
+            value: accumulated_fees,
+        };
 
         let mut blob_public_inputs = [BlockBlobPublicInputs::empty(); AZTEC_MAX_EPOCH_DURATION];
         blob_public_inputs[0] = block_blob_public_inputs;

noir-projects/noir-protocol-circuits/crates/rollup-lib/src/block_root/empty_block_root_rollup_inputs.nr

@@ -52,15 +52,17 @@ impl EmptyBlockRootRollupInputs {
 
 mod tests {
     use crate::{
-        abis::block_root_or_block_merge_public_inputs::BlockRootOrBlockMergePublicInputs,
+        abis::block_root_or_block_merge_public_inputs::{
+            BlockRootOrBlockMergePublicInputs, FeeRecipient,
+        },
         block_root::empty_block_root_rollup_inputs::{
             EMPTY_EFFECT_BLOB_CHALLENGE_Z, EMPTY_EFFECT_BLOB_COMMITMENT, EMPTY_EFFECT_BLOBS_HASH,
             EmptyBlockRootRollupInputs,
         },
         tests::rollup_fixture_builder::RollupFixtureBuilder,
     };
     use std::hash::poseidon2::Poseidon2;
-    use types::{abis::sponge_blob::SpongeBlob, tests::utils::assert_array_eq};
+    use types::{abis::sponge_blob::SpongeBlob, address::EthAddress, tests::utils::assert_array_eq};
 
     pub struct TestBuilder {
         pub inputs: RollupFixtureBuilder,
@@ -93,7 +95,10 @@ mod tests {
         assert(output.previous_block_hash != output.end_block_hash);
         assert_eq(output.start_global_variables, output.end_global_variables);
         assert_eq(output.out_hash, 0);
-        assert_array_eq(output.fees, []);
+        assert_array_eq(
+            output.fees,
+            [FeeRecipient { recipient: builder.inputs.global_variables.coinbase, value: 0 }],
+        );
 
         // The below values are generated from block_building_helper.test.ts.
         let expected_empty_effect_blobs_hash =
@@ -130,6 +135,7 @@ mod tests {
     unconstrained fn correct_empty_block_root_rollup_output_for_padding() {
         let mut builder = TestBuilder::new();
         builder.is_padding = true;
+        builder.inputs.global_variables.coinbase = EthAddress::from_field(0);
 
         let output = builder.execute();