Skip to content

Commit c55088e

Browse files
authored
chore: Disable blobscan by default (#13742)
Disables blobscan as blob archive fallback since its API has not been reliable enough. We keep it enabled in k8s config for our blobsink though.
1 parent 5c8a993 commit c55088e

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

spartan/aztec-network/templates/blob-sink.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,8 @@ spec:
9999
fieldPath: metadata.namespace
100100
- name: BLOB_SINK_PORT
101101
value: "{{ .Values.blobSink.service.nodePort }}"
102+
- name: BLOB_SINK_ARCHIVE_API_URL
103+
value: "{{ .Values.blobSink.archiveApiUrl }}"
102104
- name: LOG_LEVEL
103105
value: "{{ .Values.blobSink.logLevel }}"
104106
- name: LOG_JSON

spartan/aztec-network/values/alpha-testnet.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ network:
2424

2525
blobSink:
2626
enabled: true
27+
archiveApiUrl: "https://api.sepolia.blobscan.com"
2728
dataStoreConfig:
2829
dataDir: "/data"
2930
storageSize: "128Gi"

yarn-project/blob-sink/src/archive/factory.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,18 @@ import type { BlobSinkArchiveApiConfig } from './config.js';
22
import { createBlobArchiveClient } from './factory.js';
33

44
describe('BlobscanArchiveClient factory', () => {
5-
it.each<[string, BlobSinkArchiveApiConfig, boolean, string]>([
6-
['empty config', {}, false, ''],
7-
['random chain, no custom URL', { l1ChainId: 23478 }, false, ''],
5+
it.each<[string, BlobSinkArchiveApiConfig, boolean, string | undefined]>([
6+
['empty config', {}, false, undefined],
7+
['random chain, no custom URL', { l1ChainId: 23478 }, false, undefined],
88
[
99
'random chain, custom URL',
1010
{ l1ChainId: 23478, archiveApiUrl: 'https://example.com' },
1111
true,
1212
'https://example.com/',
1313
],
14-
['ETH mainnet default URL', { l1ChainId: 1 }, true, 'https://api.blobscan.com/'],
14+
['ETH mainnet no default URL', { l1ChainId: 1 }, false, undefined],
1515
['ETH mainnet custom URL', { l1ChainId: 1, archiveApiUrl: 'https://example.com' }, true, 'https://example.com/'],
16-
['Sepolia default URL', { l1ChainId: 11155111 }, true, 'https://api.sepolia.blobscan.com/'],
16+
['Sepolia no default URL', { l1ChainId: 11155111 }, false, undefined],
1717
['Seplia custom URL', { l1ChainId: 11155111, archiveApiUrl: 'https://example.com' }, true, 'https://example.com/'],
1818
])('can instantiate a client: %s', (_, cfg, clientExpected, expectedBaseUrl) => {
1919
const client = createBlobArchiveClient(cfg);

yarn-project/blob-sink/src/archive/factory.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,5 @@ export function createBlobArchiveClient(config: BlobSinkConfig): BlobArchiveClie
77
return new BlobscanArchiveClient(config.archiveApiUrl);
88
}
99

10-
if (config.l1ChainId === 1) {
11-
return new BlobscanArchiveClient('https://api.blobscan.com');
12-
} else if (config.l1ChainId === 11155111) {
13-
return new BlobscanArchiveClient('https://api.sepolia.blobscan.com');
14-
}
15-
1610
return undefined;
1711
}

0 commit comments

Comments
 (0)