Skip to content

Commit 06886ed

Browse files
committed
Test for version type
1 parent d21615a commit 06886ed

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

src/class_sqlThread.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ def sql_schema_version(self, setter):
9797
"""
9898
Update version with one level
9999
"""
100+
100101
if setter:
101102
query = "UPDATE settings SET value=CAST(value AS INT) + 1 WHERE key = 'version'"
102103
self.cur.execute(query)
@@ -290,8 +291,9 @@ def upgrade_config_setting_version(self):
290291
def error_handler(err, custom_error):
291292
if str(err) == 'database or disk is full':
292293
logger.fatal(
293-
f'(While {custom_error}) Alert: Your disk or data storage volume is full.'
294-
' sqlThread will now exit.'
294+
"(While {}) Alert: Your disk or data storage volume is full. sqlThread will now exit.".format(
295+
custom_error
296+
)
295297
)
296298
queues.UISignalQueue.put((
297299
'alert', (

src/tests/test_sqlthread.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ def wrapper(*args):
9090
self = args[0]
9191
func_name = func.__name__
9292
version = func_name.rsplit('_', 1)[-1]
93-
9493
self.test_db._upgrade_one_level_sql_statement(int(version)) # pylint: disable= W0212, protected-access
9594

9695
# Update versions DB mocking
@@ -213,3 +212,13 @@ def test_bm_db_version_10(self):
213212
self.test_db.cur.execute("SELECT * FROM addressbook WHERE label='test' ") # noqa
214213
res = self.test_db.cur.fetchall()
215214
self.assertEqual(res[0][0], label, "Data not migrated for version 10")
215+
216+
@version
217+
def test_bm_db_version_type(self):
218+
"""
219+
Test version type
220+
"""
221+
self.test_db.cur.execute('''INSERT INTO settings VALUES('version','test_string')''') # noqa
222+
version = self.test_db.cur.execute("SELECT * FROM settings WHERE key='version'")
223+
res = version.fetchall()
224+
self.assertEqual(type(res[0][1]), int)

0 commit comments

Comments
 (0)