Automation side panel: 480px default width + resizable#18460
Open
Automation side panel: 480px default width + resizable#18460
Conversation
This reverts commit f52d261.
Collaborator
Author
|
@cubic-dev-ai review |
Contributor
@melohagan I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: baa2b85d71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Confidence score: 3/5
- There is a concrete regression risk in
packages/builder/src/components/common/resizable.ts: double-click reset can now set size to0pxwheninitialValueis missing, which may collapse panels unexpectedly for users. - I’m scoring this as moderate risk because the issue is user-facing behavior (severity 6/10, high confidence 9/10), even though it appears localized to resize/reset logic.
- Pay close attention to
packages/builder/src/components/common/resizable.ts- reset behavior should restore default CSS sizing rather than forcing collapsed dimensions.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/builder/src/components/common/resizable.ts">
<violation number="1" location="packages/builder/src/components/common/resizable.ts:126">
P2: Double-click reset now forces `0px` when no `initialValue` is provided, which can collapse panels instead of restoring their default CSS size.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
…click" This reverts commit 69b18b4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increase the automation side panel default width from 400px to 480px and add horizontal resizing.
Implemented a reusable
ResizablePanelwrapper so this behavior can be reused across right/left side panels.Addresses
Screenshots
side.panel.mov
Launchcontrol
Automation side panels in the builder are now wider by default and can be resized by dragging the divider.