Skip to content

Commit abed673

Browse files
author
root
committed
address the comments
1 parent dd6f7f7 commit abed673

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

docs/fornax_test/830_release_testplan.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Fornax End-to-End Test for 2021-8-30 Release
22

3-
This test suite verifies the features for 2021-8-30 release. Detaile explanation about these features are given in [design doc](https://github.com/CentaurusInfra/fornax/tree/main/docs/fornax-design/530_design.md).
3+
This test suite verifies the features for 2021-8-30 release. Detailed explanation about these features are given in [design doc](https://github.com/CentaurusInfra/fornax/tree/main/docs/fornax-design/530_design.md).
44

55
The following tests assume four clusters, denoted as A,B,C and D, are created and configured for tests. A,B,C are kubernetes clusters created using kubeadm, while cluster D is an arktos cluster started by running script arktos-up.sh (https://github.com/CentaurusInfra/arktos/blob/master/hack/arktos-up.sh). These clusters are configured in a hierarchical topology, where Cluster B is an edge cluster to Cluster A, C edge to B, and D edge to C. Detailed instructions on how to configure the hierarchical connection among these clusters are given in the doc test_cluster_setup.md in the same directory as this doc.
66

@@ -15,7 +15,7 @@ Test Case 1: Register Hierarchical Edge Clusters with Cloud
1515

1616
Test Case 3: An edge cluster re-connects to the cloud
1717

18-
Test Case 5: An edge cluster continue to work when disconnected from the cloud
18+
Test Case 5: An edge cluster continues to work when disconnected from the cloud
1919

2020
Test Case 6: An edge cluster conintues to monintor its sub-edge-clusters when disconnected from cloud
2121

@@ -35,15 +35,15 @@ Test Case 10: The mission status of a cluster is "cluster unreachable" if cluste
3535

3636
Test Case 11: Delete workload to edge clusters using mission
3737

38-
Test Case 12: Deploy workload to an edge cluster with specific name
38+
Test Case 12: Deploy workload to an edge cluster with a specific name
3939

4040
Test Case 13: Deploy workload to selective edge clusters with given labels
4141

4242
Test Case 15: An edge cluster picks up the new mission added during its disconnection when reconnected to the cloud
4343

44-
Test Case 16: An edge cluster updates the mission updated during its disconnection when reconnected to the cloud
44+
Test Case 16: An edge cluster picks up the change when reconnected if the mission is updated during its disconnection
4545

46-
Test Case 17: An edge cluster deletes the mission deleted during its disconnection when reconnected to the cloud
46+
Test Case 17: An edge cluster deletes a mission when reconnected if the mission is deleted during its disconnection
4747

4848
Test Case 18: The mission content deleted in edge cluster will be re-instated
4949

@@ -61,10 +61,10 @@ Test Case 20: The status of edge cluster is "Unhealthy" if the clusterd is conne
6161

6262
## Test Cases
6363

64-
**Note: By default, the commands in this doc are run from the root directory of the fornax repo. If not specified, the command is run on the operating machine of Cluster A, which will be referred as "root operator machine" in the rest of this document.**
64+
**Note: By default, the commands in this doc are run from the root directory of the fornax repo. If not specified, the command is run on the machine of Cluster A, which will be referred as "root operator machine" in the rest of this document.**
6565

6666

67-
**Test Case 1: Register Cascading Edge Clusters with Cloud**
67+
**Test Case 1: Register Hierarchical Edge Clusters with Cloud**
6868

6969
Step 1: start kubeedge cloudcore in the root operator machine, using command:
7070
```
@@ -169,7 +169,7 @@ kubectl get deployment --kubeconfig=[edge_cluster_kubeconfig]
169169
Verify that the deployment specified in the mission content is created in the edge clusters of B, C, D.
170170

171171

172-
**Test Case 5: An edge cluster continue to work when disconnected from the cloud**
172+
**Test Case 5: An edge cluster continues to work when disconnected from the cloud**
173173

174174
Continuing from the previous test case, do the following:
175175

@@ -286,7 +286,7 @@ kubectl get deployment --kubeconfig=[edge_cluster_kubeconfig]
286286
```
287287
Verify that the deployment specified in the mission content is gone in each edge cluster.
288288

289-
**Test Case 12: Deploy workload to an edge cluster with specific name**
289+
**Test Case 12: Deploy workload to an edge cluster with a specific name**
290290

291291
Step 1. update tests/edgecluster/data/missions/deployment-to-given-clusters.yaml to change the value of spec/placement/cluster/Name to be the name of cluster C.
292292

@@ -427,7 +427,7 @@ kubectl get deployment --kubeconfig=[edge_cluster_kubeconfig]
427427
```
428428
Verify that the deployment specified in the mission content is created in the edge clusters B, C and D.
429429

430-
**Test Case 16: An edge cluster updates the mission updated during its disconnection when reconnected to the cloud**
430+
**Test Case 16: An edge cluster picks up the change when reconnected if the mission is updated during its disconnection**
431431

432432
Continuing from the previous test case, do the following:
433433

@@ -468,7 +468,7 @@ kubectl get deployment --kubeconfig=[edge_cluster_kubeconfig]
468468
Verify that the number of replicas in the deployment is updated in the edge clusters B, C and D.
469469

470470

471-
**Test Case 17: An edge cluster deletes the mission deleted during its disconnection when reconnected to the cloud**
471+
**Test Case 17: An edge cluster deletes a mission when reconnected if the mission is deleted during its disconnection **
472472

473473
Continuing from the previous test case, do the following:
474474

docs/fornax_test/test_clusters_setup.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Copy the kubeconfig files of cluster A, B, C and D to the root operator machine.
3131
### In machine A, do the following
3232

3333

34-
1. Clone a repo of https://github.com/CentaurusInfra/fornax, sync to latest version of main branch.
34+
1. Clone a repo of https://github.com/CentaurusInfra/fornax, sync to the branch/commit to test.
3535

3636
Build the binaries of edgecore and cloudcore using the commands
3737
```
@@ -75,7 +75,7 @@ kubectl apply -f build/crds/edgecluster/edgecluster_v1.yaml
7575

7676

7777
### In machine B
78-
1. Clone a repo of https://github.com/CentaurusInfra/fornax, sync to latest version of main branch.
78+
1. Clone a repo of https://github.com/CentaurusInfra/fornax, sync to the branch/commit to test.
7979

8080
Build the binaries of edgecore and cloudcore using the commands
8181
```
@@ -96,7 +96,7 @@ tests/edgecluster/hack/update_edgecore_config.sh [cluster_A_kubeconfig_file]
9696
```
9797

9898
### In machine C
99-
1. Clone a repo of https://github.com/CentaurusInfra/fornax, sync to latest version of main branch.
99+
1. Clone a repo of https://github.com/CentaurusInfra/fornax, sync to the branch/commit to test.
100100

101101
Build the binaries of edgecore and cloudcore using the commands
102102
```
@@ -117,7 +117,7 @@ tests/edgecluster/hack/update_edgecore_config.sh [cluster_B_kubeconfig_file]
117117
```
118118

119119
### In machine D
120-
1. Clone a repo of https://github.com/CentaurusInfra/fornax, sync to latest version of main branch.
120+
1. Clone a repo of https://github.com/CentaurusInfra/fornax, sync to the branch/commit to test.
121121

122122
Build the binary of edgecore
123123
```

pkg/util/flag/flags.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@ const defaultConfigFlagName = "defaultconfig"
7777
const edgeclusterConfigFlagName = "edgeclusterconfig"
7878

7979
var (
80-
minConfigFlag = Config(minConfigFlagName, ConfigFalse, "Print min configuration for reference, users can refer to it to create their own configuration files, it is suitable for beginners.")
81-
defaultConfigFlag = Config(defaultConfigFlagName, ConfigFalse, "Print default configuration for reference, users can refer to it to create their own configuration files, it is suitable for advanced users.")
82-
edgeclusterConfigFlag = Config(edgeclusterConfigFlagName, ConfigFalse, "Print edgecluster configuration for reference, users can refer to it to create their own configuration files, it is suitable for advanced users.")
80+
minConfigFlag = Config(minConfigFlagName, ConfigFalse, "Print min configuration for reference. Users can refer to it to create their own configuration files. It is suitable for beginners.")
81+
defaultConfigFlag = Config(defaultConfigFlagName, ConfigFalse, "Print default configuration for reference. Users can refer to it to create their own configuration files. It is suitable for advanced users.")
82+
edgeclusterConfigFlag = Config(edgeclusterConfigFlagName, ConfigFalse, "Print edgecluster configuration for reference. Users can refer to it to create their own configuration files. It is suitable for advanced users.")
8383
)
8484

8585
// AddFlags registers this package's flags on arbitrary FlagSets, such that they point to the

0 commit comments

Comments
 (0)