Skip to content

Commit 48e7b16

Browse files
Kuba MikulskiDevtools-frontend LUCI CQ
authored andcommitted
[TDR] Remove TODOs linked to issue 40186079
This CL was generated by an AI agent and verified by the CL owner before sending for review. The TODOs were identified as stale by TODO Removal Agent (http://go/dead-todo-removal-agent). * Detailed reasoning can be found in the CL comments. * How to review this CL: http://go/tdr-review-instructions * To opt-out from future reviews: http://go/tdr-opt-out. The TODO suggests a refactoring that was tracked by a bug now marked as 'OBSOLETE'. The bug was closed because the proposed change was deemed "not directly actionable," making the TODO's goal irrelevant. Change-Id: Idde6aaab23a022816850cb9548f09797435e7cdc Bug: 40186079 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7241814 Reviewed-by: Danil Somsikov <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Kuba Mikulski <[email protected]>
1 parent 33de929 commit 48e7b16

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

front_end/core/sdk/NetworkManager.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2716,13 +2716,6 @@ export interface Conditions {
27162716
packetLoss?: number;
27172717
packetQueueLength?: number;
27182718
packetReordering?: boolean;
2719-
// TODO(crbug.com/1219425): In the future, it might be worthwhile to
2720-
// consider avoiding mixing up presentation state (e.g.: displayed
2721-
// titles) with behavioral state (e.g.: the throttling amounts). In
2722-
// this particular case, the title (along with other properties)
2723-
// doubles as both part of group of fields which (loosely) uniquely
2724-
// identify instances, as well as the literal string displayed in the
2725-
// UI, which leads to complications around persistance.
27262719
// TODO(crbug.com/422682525): make this just a function because we use lazy string everywhere.
27272720
title: string|(() => string);
27282721
// Instances may be serialized to local storage, so localized titles

0 commit comments

Comments
 (0)