Skip to content

Commit 5e129ae

Browse files
Natallia HarshunovaDevtools-frontend LUCI CQ
authored andcommitted
Update Chrome (for Testing) PIN
Chromium pin updated to 145.0.7579.0 Roll created at https://cr-buildbucket.appspot.com/build/8695327614455512065 Bug: none Change-Id: I3c6661359f75947a9e59dacb4a1b7af35e3b509f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7264906 Reviewed-by: Yang Guo <[email protected]> Reviewed-by: Natallia Harshunova <[email protected]> Commit-Queue: Natallia Harshunova <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]>
1 parent 24aab00 commit 5e129ae

File tree

3 files changed

+31
-23
lines changed

3 files changed

+31
-23
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ vars = {
4949
# Chrome version used for tests. It should be regularly updated to
5050
# match the Canary version listed here:
5151
# https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json
52-
'chrome': '145.0.7573.0',
52+
'chrome': '145.0.7579.0',
5353

5454
# 'magic' text to tell depot_tools that git submodules should be accepted but
5555
# but parity with DEPS file is expected.

front_end/panels/screencast/ScreencastApp.test.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,20 @@ import {describeWithMockConnection} from '../../testing/MockConnection.js';
1010
import * as Screencast from './screencast.js';
1111

1212
describeWithMockConnection('ScreencastApp', () => {
13-
it('can start casting', async () => {
14-
const screencastApp = new Screencast.ScreencastApp.ScreencastApp();
13+
let screencastApp: Screencast.ScreencastApp.ScreencastApp|undefined;
14+
15+
afterEach(() => {
16+
screencastApp?.rootView?.detach();
17+
});
18+
// Blocks the CfT roll since https://crrev.com/c/7253957
19+
it.skip('[crbug.com/469344861]can start casting', async () => {
20+
screencastApp = new Screencast.ScreencastApp.ScreencastApp();
1521
screencastApp.presentUI(document);
1622
const tabTarget = createTarget({type: SDK.Target.Type.TAB});
1723
createTarget({parentTarget: tabTarget, subtype: 'prerender'});
1824
const target = createTarget({parentTarget: tabTarget});
1925
const screenCaptureModel = target.model(SDK.ScreenCaptureModel.ScreenCaptureModel);
2026
assert.exists(screenCaptureModel);
2127
await expectCall(sinon.stub(screenCaptureModel, 'startScreencast'));
22-
screencastApp.rootView?.detach();
2328
});
2429
});

test/e2e/network/network.test.ts

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -122,24 +122,27 @@ describe('The Network Tab', function() {
122122
describe('with durable messages', function() {
123123
setup({enabledFeatures: ['DevToolsEnableDurableMessages']});
124124

125-
it('can persist requests across cross-origin navigation', async ({devToolsPage, inspectedPage}) => {
126-
await navigateToNetworkTabEmptyPage(devToolsPage, inspectedPage);
127-
await setPersistLog(true, devToolsPage);
128-
129-
await navigateToNetworkTab('headers-and-payload.html', devToolsPage, inspectedPage);
130-
await waitForSomeRequestsToAppear(3, devToolsPage);
131-
132-
// Navigate to a different origin's page
133-
await inspectedPage.goToResourceWithCustomHost('devtools.test', 'host/page-with-oopif.html');
134-
135-
// Introspect a request from the first navigation
136-
await selectRequestByName('headers-and-payload.html', {devToolsPage});
137-
const networkView = await devToolsPage.waitFor('.network-item-view');
138-
await devToolsPage.click('[aria-label=Response][role="tab"]', {
139-
root: networkView,
140-
});
141-
await devToolsPage.waitFor('[aria-label=Response][role=tab][aria-selected=true]', networkView);
142-
await devToolsPage.waitFor('devtools-text-editor');
143-
});
125+
// Blocks the CfT roll since https://crrev.com/c/7264906
126+
it.skip(
127+
'[crbug.com/469405354]can persist requests across cross-origin navigation',
128+
async ({devToolsPage, inspectedPage}) => {
129+
await navigateToNetworkTabEmptyPage(devToolsPage, inspectedPage);
130+
await setPersistLog(true, devToolsPage);
131+
132+
await navigateToNetworkTab('headers-and-payload.html', devToolsPage, inspectedPage);
133+
await waitForSomeRequestsToAppear(3, devToolsPage);
134+
135+
// Navigate to a different origin's page
136+
await inspectedPage.goToResourceWithCustomHost('devtools.test', 'host/page-with-oopif.html');
137+
138+
// Introspect a request from the first navigation
139+
await selectRequestByName('headers-and-payload.html', {devToolsPage});
140+
const networkView = await devToolsPage.waitFor('.network-item-view');
141+
await devToolsPage.click('[aria-label=Response][role="tab"]', {
142+
root: networkView,
143+
});
144+
await devToolsPage.waitFor('[aria-label=Response][role=tab][aria-selected=true]', networkView);
145+
await devToolsPage.waitFor('devtools-text-editor');
146+
});
144147
});
145148
});

0 commit comments

Comments
 (0)