Skip to content

Commit 8ce7dcc

Browse files
pfaffeDevtools-frontend LUCI CQ
authored andcommitted
Fix lighthouse test
Fixed: 466057104 Change-Id: I737c02e6609fd0583748f9c20e8343c904789aee Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7260277 Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Alex Rudenko <[email protected]> Auto-Submit: Philip Pfaffe <[email protected]>
1 parent b3ff583 commit 8ce7dcc

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

test/e2e/lighthouse/devtools-settings.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ async function blockCss(devToolsPage: DevToolsPage) {
5050
const networkManager = SDKModule.NetworkManager.MultitargetNetworkManager.instance();
5151
networkManager.requestConditions.conditionsEnabled = true;
5252
networkManager.requestConditions.add(
53-
SDKModule.NetworkManager.RequestCondition.createFromSetting({enabled: true, url: '*.css'}));
53+
SDKModule.NetworkManager.RequestCondition.createFromSetting({enabled: true, url: '*://*:*/*.css'}));
5454
});
5555
}
5656

@@ -59,8 +59,7 @@ describe('DevTools', function() {
5959
this.timeout(60_000);
6060

6161
describe('request blocking', () => {
62-
// https://crbug.com/466057104 the feature roll has make this test fail
63-
it.skip('[crbug.com/466057104] is respected during a lighthouse run', async ({devToolsPage, inspectedPage}) => {
62+
it('is respected during a lighthouse run', async ({devToolsPage, inspectedPage}) => {
6463
expectErrors();
6564
await blockCss(devToolsPage);
6665
await navigateToLighthouseTab('lighthouse/hello.html', devToolsPage, inspectedPage);

0 commit comments

Comments
 (0)