refactor: replace hardcoded outlier factor for improved readability

art049 · art049 · commit 325cb00ac6f9 · 2025-01-28T12:09:04.000+01:00
diff --git a/src/pytest_codspeed/instruments/walltime.py b/src/pytest_codspeed/instruments/walltime.py
@@ -26,6 +26,8 @@
 TIMER_RESOLUTION_NS = get_clock_info("perf_counter").resolution * 1e9
 DEFAULT_MIN_ROUND_TIME_NS = TIMER_RESOLUTION_NS * 1_000_000
 
+IQR_OUTLIER_FACTOR = 1.5
+
 
 @dataclass
 class BenchmarkConfig:
@@ -89,7 +91,10 @@ def from_list(
             )
         iqr_ns = q3_ns - q1_ns
         iqr_outlier_rounds = sum(
-            1 for t in times_ns if t < q1_ns - 1.5 * iqr_ns or t > q3_ns + 1.5 * iqr_ns
+            1
+            for t in times_ns
+            if t < q1_ns - IQR_OUTLIER_FACTOR * iqr_ns
+            or t > q3_ns + IQR_OUTLIER_FACTOR * iqr_ns
         )
         stdev_outlier_rounds = sum(
             1

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,8 @@`
`26`	`26`	`TIMER_RESOLUTION_NS = get_clock_info("perf_counter").resolution * 1e9`
`27`	`27`	`DEFAULT_MIN_ROUND_TIME_NS = TIMER_RESOLUTION_NS * 1_000_000`
`28`	`28`
	`29`	`+IQR_OUTLIER_FACTOR = 1.5`
	`30`	`+`
`29`	`31`
`30`	`32`	`@dataclass`
`31`	`33`	`class BenchmarkConfig:`
`@@ -89,7 +91,10 @@ def from_list(`
`89`	`91`	`)`
`90`	`92`	`iqr_ns = q3_ns - q1_ns`
`91`	`93`	`iqr_outlier_rounds = sum(`
`92`		`- 1 for t in times_ns if t < q1_ns - 1.5 * iqr_ns or t > q3_ns + 1.5 * iqr_ns`
	`94`	`+ 1`
	`95`	`+ for t in times_ns`
	`96`	`+ if t < q1_ns - IQR_OUTLIER_FACTOR * iqr_ns`
	`97`	`+ or t > q3_ns + IQR_OUTLIER_FACTOR * iqr_ns`
`93`	`98`	`)`
`94`	`99`	`stdev_outlier_rounds = sum(`
`95`	`100`	`1`