feat(CREATE): add configuration option to enable/disable database writes

Author: benoitdm-oslandia

config/pg_featureserv.toml.example

@@ -68,6 +68,9 @@ WriteTimeoutSec = 30
 # Publish functions from these schemas (default is publish postgisftw)
 # FunctionIncludes = [ "postgisftw", "schema2" ]
 
+# Allow write changes to database. Default is to read only.
+# AllowWrite = false
+
 [Paging]
 # The default number of features in a response
 LimitDefault = 20

hugo/content/installation/configuration.md

@@ -118,6 +118,9 @@ WriteTimeoutSec = 30
 # Publish functions from these schemas (default is publish postgisftw)
 # FunctionIncludes = [ "postgisftw", "schema2" ]
 
+# Allow write changes to database. Default is to read only.
+# AllowWrite = false
+
 [Paging]
 # The default number of features in a response
 LimitDefault = 20

internal/conf/config.go

@@ -44,6 +44,7 @@ func setDefaultConfig() {
 	viper.SetDefault("Database.TableIncludes", []string{})
 	viper.SetDefault("Database.TableExcludes", []string{})
 	viper.SetDefault("Database.FunctionIncludes", []string{"postgisftw"})
+	viper.SetDefault("Database.AllowWrite", false)
 
 	viper.SetDefault("Paging.LimitDefault", 10)
 	viper.SetDefault("Paging.LimitMax", 1000)
@@ -94,6 +95,7 @@ type Database struct {
 	TableIncludes         []string
 	TableExcludes         []string
 	FunctionIncludes      []string
+	AllowWrite            bool
 }
 
 // Metadata config

internal/service/db_test/handler_db_test.go

@@ -12,6 +12,7 @@ import (
 	"testing"
 
 	"github.com/CrunchyData/pg_featureserv/internal/api"
+	"github.com/CrunchyData/pg_featureserv/internal/conf"
 	"github.com/CrunchyData/pg_featureserv/internal/data"
 	"github.com/CrunchyData/pg_featureserv/internal/service"
 	"github.com/CrunchyData/pg_featureserv/util"
@@ -33,6 +34,8 @@ type geojsonFeatureData struct {
 }
 
 func TestMain(m *testing.M) {
+	conf.Configuration.Database.AllowWrite = true
+
 	db = util.CreateTestDb()
 	defer util.CloseTestDb(db)
 
@@ -50,23 +53,6 @@ func TestProperDbInit(t *testing.T) {
 	util.Equals(t, 2, len(tables), "# table in DB")
 }
 
-func TestTestPropertiesAllFromDb(t *testing.T) {
-	/*rr := hTest.DoRequest(t, "/collections/mock_a/items?limit=2")
-
-	var v FeatureCollection
-	errUnMarsh := json.Unmarshal(hTest.ReadBody(rr), &v)
-	util.Assert(t, errUnMarsh == nil, fmt.Sprintf("%v", errUnMarsh))
-
-	// Note that JSON numbers are read as float64
-	util.Equals(t, 2, len(v.Features), "# features")
-	util.Equals(t, 4, len(v.Features[0].Props), "feature 1 # properties")
-
-	util.Equals(t, "propA", v.Features[0].Props["prop_a"], "feature 1 # property A")
-	util.Equals(t, 1.0, v.Features[0].Props["prop_b"], "feature 1 # property B")
-	util.Equals(t, "propC", v.Features[0].Props["prop_c"], "feature 1 # property C")
-	util.Equals(t, 1.0, v.Features[0].Props["prop_d"], "feature 1 # property D")*/
-}
-
 func TestCreateFeatureWithBadGeojsonInputDb(t *testing.T) {
 	var header = make(http.Header)
 	header.Add("Content-Type", "application/geo+json")

internal/service/handler.go

@@ -61,9 +61,12 @@ func InitRouter(basePath string) *mux.Router {
 
 	addRoute(router, "/collections/{id}/items", handleCollectionItems)
 	addRoute(router, "/collections/{id}/items.{fmt}", handleCollectionItems)
-	addRouteWithMethod(router, "/collections/{id}/items", handleCreateCollectionItem, "POST")
 
-	addRoute(router, "/collections/{id}/schema", handleCollectionSchemas)
+	if conf.Configuration.Database.AllowWrite {
+		addRouteWithMethod(router, "/collections/{id}/items", handleCreateCollectionItem, "POST")
+
+		addRoute(router, "/collections/{id}/schema", handleCollectionSchemas)
+	}
 
 	addRoute(router, "/collections/{id}/items/{fid}", handleItem)
 	addRoute(router, "/collections/{id}/items/{fid}.{fmt}", handleItem)

internal/service/handler_test.go

@@ -24,6 +24,7 @@ import (
 	"testing"
 
 	"github.com/CrunchyData/pg_featureserv/internal/api"
+	"github.com/CrunchyData/pg_featureserv/internal/conf"
 	"github.com/CrunchyData/pg_featureserv/internal/data"
 	"github.com/CrunchyData/pg_featureserv/util"
 )
@@ -51,6 +52,8 @@ var hTest util.HttpTesting
 var catalogMock *data.CatalogMock
 
 func TestMain(m *testing.M) {
+	conf.Configuration.Database.AllowWrite = true
+
 	catalogMock = data.CatMockInstance()
 	catalogInstance = catalogMock