Skip to content

Commit 25518cd

Browse files
authored
Adding localization for the sign in button states (#13612)
1 parent 83161e3 commit 25518cd

File tree

4 files changed

+20
-3
lines changed

4 files changed

+20
-3
lines changed

src/DynamoCoreWpf/Properties/Resources.Designer.cs

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DynamoCoreWpf/Properties/Resources.en-US.resx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3479,4 +3479,7 @@ In certain complex graphs or host program scenarios, Automatic mode may cause in
34793479
<data name="PreferencesViewBetaTag" xml:space="preserve">
34803480
<value>Beta</value>
34813481
</data>
3482-
</root>
3482+
<data name="SplashScreenSigningIn" xml:space="preserve">
3483+
<value>Signing In</value>
3484+
</data>
3485+
</root>

src/DynamoCoreWpf/Properties/Resources.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3466,4 +3466,7 @@ In certain complex graphs or host program scenarios, Automatic mode may cause in
34663466
<data name="PreferencesViewBetaTag" xml:space="preserve">
34673467
<value>Beta</value>
34683468
</data>
3469+
<data name="SplashScreenSigningIn" xml:space="preserve">
3470+
<value>Signing In</value>
3471+
</data>
34693472
</root>

src/DynamoCoreWpf/Views/SplashScreen/SplashScreen.xaml.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,7 @@ internal async void SetSignInStatus(bool status)
347347
{
348348
if (webView?.CoreWebView2 != null)
349349
{
350-
await webView.CoreWebView2.ExecuteScriptAsync("window.setSignInStatus({" +
351-
$"signInTitle: \"" + (status ? Wpf.Properties.Resources.SplashScreenSignOut : Wpf.Properties.Resources.SplashScreenSignIn).ToString() + "\"," +
350+
await webView.CoreWebView2.ExecuteScriptAsync("window.setSignInStatus({" +
352351
$"signInStatus: \"" + status + "\"})");
353352
}
354353
}
@@ -365,6 +364,9 @@ await webView.CoreWebView2.ExecuteScriptAsync("window.setLabels({" +
365364
$"launchTitle: \"{Wpf.Properties.Resources.SplashScreenLaunchTitle}\"," +
366365
$"importSettingsTitle: \"{Wpf.Properties.Resources.ImportSettingsDialogTitle}\"," +
367366
$"showScreenAgainLabel: \"{Wpf.Properties.Resources.SplashScreenShowScreenAgainLabel}\"," +
367+
$"signInTitle: \"{Wpf.Properties.Resources.SplashScreenSignIn}\"," +
368+
$"signOutTitle: \"{Wpf.Properties.Resources.SplashScreenSignOut}\"," +
369+
$"signingInTitle: \"{Wpf.Properties.Resources.SplashScreenSigningIn}\"," +
368370
$"importSettingsTooltipDescription: \"{Wpf.Properties.Resources.ImportPreferencesInfo}\"" + "})");
369371
}
370372
}

0 commit comments

Comments
 (0)