Fix bug - Can not get StairsRun Parent Element (#2624)

Author: ZiyunShang

CHANGELOG.md

@@ -7,6 +7,7 @@
 * Add some View Nodes - View.HideCategoriesTemporary, View.HideElementsTemporary, View.IsolateCategoriesTemporary, View.IsolateElementsTemporary.
 * Improve DuplicateSheet Node - add "duplicateWithContents" option, add default suffix value when prefix & suffix are both empty.
 * Improve DuplicateSheet Node - Set Sheet information when duplicating; Improve View Temporary Nodes.
+* Fix bug - Element.GetParentElement can't get StairsRun Parent Element.
 
 ## 0.2.18
 * Add a Category ScheduleOnSheet and its nodes - ScheduleOnSheet.Sheet, ScheduleOnSheet.Schedule, ScheduleOnSheet.BySheetViewLocation, ScheduleOnSheet.Location and ScheduleOnSheet.SetLocation

src/Libraries/RevitNodes/Elements/Element.cs

@@ -389,6 +389,7 @@ public static int[] Delete(Element element)
             return deletedElements; 
         }
 
+        #region Get/Set Parameter
         /// <summary>
         /// Get a parameter by name of an element
         /// </summary>
@@ -444,6 +445,30 @@ public object GetParameterValueByName(string parameterName)
             return Revit.Elements.InternalUtilities.ElementUtils.GetParameterValue(param);
         }
 
+        /// <summary>
+        /// Set one of the element's parameters.
+        /// </summary>
+        /// <param name="parameterName">The name of the parameter to set.</param>
+        /// <param name="value">The value.</param>
+        public Element SetParameterByName(string parameterName, object value)
+        {
+            var param = GetParameterByName(parameterName);
+
+            if (param == null)
+                throw new Exception(Properties.Resources.ParameterNotFound);
+
+            TransactionManager.Instance.EnsureInTransaction(DocumentManager.Instance.CurrentDBDocument);
+
+            var dynval = value as dynamic;
+            Revit.Elements.InternalUtilities.ElementUtils.SetParameterValue(param, dynval);
+
+            TransactionManager.Instance.TransactionTaskDone();
+
+            return this;
+        }
+        #endregion
+
+        #region Overrides & Hidden In ActiveView
         /// <summary>
         /// Override the element's color in the active view.
         /// </summary>
@@ -509,29 +534,7 @@ public bool IsHiddeninView(Revit.Elements.Views.View view)
             return InternalElement.IsHidden(view.InternalView);
         }
 
-        /// <summary>
-        /// Set one of the element's parameters.
-        /// </summary>
-        /// <param name="parameterName">The name of the parameter to set.</param>
-        /// <param name="value">The value.</param>
-        public Element SetParameterByName(string parameterName, object value)
-        {
-            var param = GetParameterByName(parameterName);
-
-            if (param == null)
-                throw new Exception(Properties.Resources.ParameterNotFound);
-
-            TransactionManager.Instance.EnsureInTransaction(DocumentManager.Instance.CurrentDBDocument);
-
-            var dynval = value as dynamic;
-            Revit.Elements.InternalUtilities.ElementUtils.SetParameterValue(param, dynval);
-
-            TransactionManager.Instance.TransactionTaskDone();
-
-            return this;
-        }
-
-
+        #endregion
 
         /// <summary>
         /// Get all of the Geometry associated with this object
@@ -819,6 +822,7 @@ protected bool IsAlive
             }
         }
 
+        #region Get Child Elements
         /// <summary>
         /// Gets the child Elements of the current Element.
         /// </summary>
@@ -930,7 +934,9 @@ private static List<Element> GetChildElementsFromStairs(Autodesk.Revit.DB.Elemen
                                                                      .ToList();
             return stairComponentElements;
         }
+        #endregion
 
+        #region Get Parent Elemnt
         /// <summary>
         /// Gets the parent element of the Element.
         /// </summary>
@@ -1025,15 +1031,23 @@ private static Autodesk.Revit.DB.Element GetParentElementFromStructuralFraming(A
         private static Autodesk.Revit.DB.Element GetParentComponentFromStairElements(Autodesk.Revit.DB.Element element)
         {
             Autodesk.Revit.DB.Element parent;
-            var stairElement = element as Autodesk.Revit.DB.Architecture.StairsLanding;
 
-            if (stairElement == null)
+            if(element is Autodesk.Revit.DB.Architecture.StairsLanding)
+            {
+                var stairElement = element as Autodesk.Revit.DB.Architecture.StairsLanding;
+                parent = stairElement.GetStairs();
+            }
+            else if(element is Autodesk.Revit.DB.Architecture.StairsRun)
+            {
+                var stairElement = element as Autodesk.Revit.DB.Architecture.StairsRun;
+                parent = stairElement.GetStairs();
+            }
+            else
                 throw new InvalidOperationException(Properties.Resources.NoParentElement);
 
-            // For StairLandings and StairRuns we use the GetStairs() to retrive the parent Stair
-            parent = stairElement.GetStairs();
             return parent;
         }
+        #endregion
 
         #region Geometry Join
         /// <summary>