common/bolt11: Fix BOLT11 hash calculation for unknown fallback address versions

Changelog-Fixed: Fixed hash calculation inconsistency when processing
invoices with unknown fallback address versions.

Author: erickcestari

common/bolt11.c

@@ -375,6 +375,18 @@ static const char *decode_f(struct bolt11 *b11,
 	size_t orig_len = *field_len;
 	const char *err;
 
+	/* Read version but don't commit to hash yet */
+	err = pull_uint(NULL, &orig_data, &orig_len, &version, 5);
+	if (err)
+			return tal_fmt(b11, "f: %s", err);
+
+	bool is_known_version = version == 17 || version == 18 || version < 17;
+
+	if (!is_known_version) {
+		return unknown_field(b11, hu5, data, field_len, 'f');
+	}
+
+	/* For known versions, process with hash */
 	err = pull_uint(hu5, data, field_len, &version, 5);
 	if (err)
 		return tal_fmt(b11, "f: %s", err);
@@ -427,12 +439,12 @@ static const char *decode_f(struct bolt11 *b11,
 				       tal_count(f));
 		}
 		fallback = scriptpubkey_witness_raw(b11, version,
-						    f, tal_count(f));
+								f, tal_count(f));
 	} else {
-		/* Restore version for unknown field! */
-		*data = orig_data;
-		*field_len = orig_len;
-		return unknown_field(b11, hu5, data, field_len, 'f');
+		// This should be unreachable because all valid versions (17, 18, or <17)
+		// are handled above. If hit, it indicates either a bug or future version
+		// not yet supported.
+		return tal_fmt(b11, "f: unknown version %"PRIu64, version);
 	}
 
 	if (b11->fallbacks == NULL)
@@ -1372,4 +1384,4 @@ char *bolt11_encode_(const tal_t *ctx,
 		output = tal_free(output);
 
 	return output;
-}
+}