configure: allow to run clang with ASAN

darosior · darosior · commit 43ca7770b89a · 2020-09-22T22:02:17.000+02:00
Prefer adding LSAN_OPTIONS="suppressions=$PWD/tests/sanitizer_suppressions/lsan" when CC=clang instead.

Signed-off-by: Antoine Poinsot &lt;darosior@protonmail.com&gt;
diff --git a/configure b/configure
@@ -223,10 +223,6 @@ $CC ${CWARNFLAGS-$BASE_WARNFLAGS} $CDEBUGFLAGS $COPTFLAGS -o $CONFIGURATOR $CONF
 echo "done"
 
 if [ "$ASAN" = "1" ]; then
-    if [ "$CC" = "clang" ]; then
-	echo "Address sanitizer (ASAN) is currently only supported with gcc"
-	exit 1
-    fi
     if [ "$VALGRIND" = "1" ]; then
 	echo "Address sanitizer (ASAN) and valgrind cannot be enabled at the same time"
 	exit 1
diff --git a/contrib/sanitizer_suppressions/asan b/contrib/sanitizer_suppressions/asan
@@ -0,0 +1,3 @@
+# process_check_funding_broadcast is racy as it operates on a data that may be
+# freed under its feet
+interceptor_via_fun:process_check_funding_broadcast
diff --git a/contrib/sanitizer_suppressions/lsan b/contrib/sanitizer_suppressions/lsan
@@ -0,0 +1,3 @@
+# Clang would detect false positive here, due to padding. See https://github.com/ElementsProject/lightning/pull/2285
+leak:ccan/ccan/autodata/autodata.c
+leak:ccan/ccan/htable/htable.c

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+# process_check_funding_broadcast is racy as it operates on a data that may be`
	`2`	`+# freed under its feet`
	`3`	`+interceptor_via_fun:process_check_funding_broadcast`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+# Clang would detect false positive here, due to padding. See https://github.com/ElementsProject/lightning/pull/2285`
	`2`	`+leak:ccan/ccan/autodata/autodata.c`
	`3`	`+leak:ccan/ccan/htable/htable.c`