channeld: wip: be able to handle the update htlc by handling the endorsed field

Signed-off-by: Vincenzo Palazzo <[email protected]>

Author: vincenzopalazzo

channeld/channeld.c

@@ -48,6 +48,7 @@
 #include <gossipd/gossip_store_wiregen.h>
 #include <gossipd/gossipd_peerd_wiregen.h>
 #include <hsmd/hsmd_wiregen.h>
+#include <stdbool.h>
 #include <stdio.h>
 #include <wally_bip32.h>
 #include <wire/peer_wire.h>
@@ -982,6 +983,7 @@ static void handle_peer_add_htlc(struct peer *peer, const u8 *msg)
 	add_err = channel_add_htlc(peer->channel, REMOTE, id, amount,
 				   cltv_expiry, &payment_hash,
 				   onion_routing_packet, tlvs->blinding_point, &htlc, NULL,
+				   tlvs->endorsed,
 				   /* We don't immediately fail incoming htlcs,
 				    * instead we wait and fail them after
 				    * they've been committed */
@@ -5270,7 +5272,8 @@ static void handle_offer_htlc(struct peer *peer, const u8 *inmsg)
 	e = channel_add_htlc(peer->channel, LOCAL, peer->htlc_id,
 			     amount, cltv_expiry, &payment_hash,
 			     onion_routing_packet, take(blinding), NULL,
-			     &htlc_fee, true);
+			     // FIXME: See what it is changing in the offers side
+			     &htlc_fee, false, true);
 	status_debug("Adding HTLC %"PRIu64" amount=%s cltv=%u gave %s",
 		     peer->htlc_id,
 		     type_to_string(tmpctx, struct amount_msat, &amount),

channeld/full_channel.c

@@ -1,3 +1,4 @@
+#include "ccan/short_types/short_types.h"
 #include "config.h"
 #include <bitcoin/psbt.h>
 #include <bitcoin/script.h>
@@ -14,6 +15,7 @@
 #include <common/memleak.h>
 #include <common/status.h>
 #include <common/type_to_string.h>
+#include <stdbool.h>
 #include <stdio.h>
   /* Needs to be at end, since it doesn't include its own hdrs */
   #include "full_channel_error_names_gen.h"
@@ -928,6 +930,7 @@ enum channel_add_err channel_add_htlc(struct channel *channel,
 				      const struct pubkey *blinding TAKES,
 				      struct htlc **htlcp,
 				      struct amount_sat *htlc_fee,
+				      const bool endorsed,
 				      bool err_immediate_failures)
 {
 	enum htlc_state state;

channeld/full_channel.h

@@ -1,11 +1,13 @@
 /* This is the full channel routines, with HTLC support. */
 #ifndef LIGHTNING_CHANNELD_FULL_CHANNEL_H
 #define LIGHTNING_CHANNELD_FULL_CHANNEL_H
+#include "ccan/short_types/short_types.h"
 #include "config.h"
 #include <channeld/channeld_htlc.h>
 #include <channeld/full_channel_error.h>
 #include <common/initial_channel.h>
 #include <common/sphinx.h>
+#include <stdbool.h>
 
 struct channel_id;
 struct existing_htlc;
@@ -138,6 +140,7 @@ enum channel_add_err channel_add_htlc(struct channel *channel,
 				      const struct pubkey *blinding TAKES,
 				      struct htlc **htlcp,
 				      struct amount_sat *htlc_fee,
+				      const bool endorsed,
 				      bool err_immediate_failures);
 
 /**

channeld/test/run-full_channel.c

@@ -168,7 +168,7 @@ static const struct htlc **include_htlcs(struct channel *channel, enum side side
 		memset(&preimage, i, sizeof(preimage));
 		sha256(&hash, &preimage, sizeof(preimage));
 		e = channel_add_htlc(channel, sender, i, msatoshi, 500+i, &hash,
-				     dummy_routing, NULL, NULL, NULL, true);
+				     dummy_routing, NULL, NULL, NULL, false, true);
 		assert(e == CHANNEL_ERR_ADD_OK);
 		htlcs[i] = channel_get_htlc(channel, sender, i);
 	}
@@ -260,7 +260,7 @@ static void send_and_fulfill_htlc(struct channel *channel,
 	sha256(&rhash, &r, sizeof(r));
 
 	assert(channel_add_htlc(channel, sender, 1337, msatoshi, 900, &rhash,
-				dummy_routing, NULL, NULL, NULL, true)
+				dummy_routing, NULL, NULL, NULL, false, true)
 	       == CHANNEL_ERR_ADD_OK);
 	htlc = channel_get_htlc(channel, sender, 1337);
 	assert(htlc);