Merge pull request #10 from amido/fix/unit-test-tags-and-pr-template

Added Test Tags where missing and also PR Template

Author: ElvenSpellmaker

.github/pull_request_template.md

@@ -0,0 +1,32 @@
+[XXXX-<Title> - Please use the Work Item number and Title as PR Name, not subtasks]
+
+#### 📲 What
+
+A description of the change.
+
+#### 🤔 Why
+
+Why it's needed, background context.
+
+#### 🛠 How
+
+More in-depth discussion of the change or implementation.
+
+#### 👀 Evidence
+
+Screenshots / external resources / links / etc.
+Link to documentation updated with changes impacted in the PR
+
+#### 🕵️ How to test
+
+Notes for QA
+
+#### ✅ Acceptance criteria Checklist
+
+- [ ] Code peer reviewed?
+- [ ] Documentation has been updated to reflect the changes?
+- [ ] Passing all automated tests, including a successful deployment?
+- [ ] Passing any exploratory testing?
+- [ ] Rebased/merged with latest changes from development and re-tested?
+- [ ] Meeting the Coding Standards?
+

java/src/test/java/com/xxAMIDOxx/xxSTACKSxx/api/v1/menu/dto/SearchMenuResultItemTest.java

@@ -1,14 +1,14 @@
 package com.xxAMIDOxx.xxSTACKSxx.api.v1.menu.dto;
 
 import nl.jqno.equalsverifier.EqualsVerifier;
+import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 
-import static org.junit.jupiter.api.Assertions.*;
-
+@Tag("Unit")
 class SearchMenuResultItemTest {
 
   @Test
   void testEquals() {
-    EqualsVerifier.simple().forClass(SearchMenuResult.class).verify();
+    EqualsVerifier.simple().forClass(SearchMenuResultItem.class).verify();
   }
 }

java/src/test/java/com/xxAMIDOxx/xxSTACKSxx/api/v1/menu/dto/SearchMenuResultTest.java

@@ -1,8 +1,10 @@
 package com.xxAMIDOxx.xxSTACKSxx.api.v1.menu.dto;
 
 import nl.jqno.equalsverifier.EqualsVerifier;
+import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 
+@Tag("Unit")
 class SearchMenuResultTest {
 
   @Test

java/src/test/java/com/xxAMIDOxx/xxSTACKSxx/api/v1/menu/impl/MenuControllerImplTest.java

@@ -100,23 +100,6 @@ public void returnMenuWhenSearchById() {
         then(response.getBody()).isEqualTo(menu);
     }
 
-    private List<Menu> createMenus(int count) {
-        List<Menu> menuList = new ArrayList<>();
-        for (int i = 0; i < count; i++) {
-            menuList.add(createMenu(i));
-        }
-        return menuList;
-    }
-
-    private Menu createMenu(int counter) {
-        return aMenu()
-                .withDescription(counter + " Menu Description")
-                .withEnabled(true)
-                .withName(counter + " Menu")
-                .withId(UUID.randomUUID().toString())
-                .build();
-    }
-
     @Test
     public void testWhenPageSizeAndNoGetsDefaultedWhenNoValueGiven() {
         // Given
@@ -185,4 +168,21 @@ public void testWhenNoRestaurantIdGivenReturnsAllResults() {
         assertThat(actual.getPageSize(), is(20));
         assertThat(actual.getResults(), is(notNullValue()));
     }
-}
+
+    private List<Menu> createMenus(int count) {
+        List<Menu> menuList = new ArrayList<>();
+        for (int i = 0; i < count; i++) {
+            menuList.add(createMenu(i));
+        }
+        return menuList;
+    }
+
+    private Menu createMenu(int counter) {
+        return aMenu()
+                .withDescription(counter + " Menu Description")
+                .withEnabled(true)
+                .withName(counter + " Menu")
+                .withId(UUID.randomUUID().toString())
+                .build();
+    }
+}