Skip to content

Commit 3fac7b2

Browse files
zecarrerazecarrera
committed
fixes linting errors
1 parent 80a0eaa commit 3fac7b2

File tree

2 files changed

+70
-69
lines changed

2 files changed

+70
-69
lines changed

‎build/azDevOps/azure/azure-pipelines-javaspring-k8s.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,8 @@ variables:
144144

145145
# Vulnerability Scan
146146
- name: vulnerability_scan
147-
value: false # setting to false to speed up testing of deploy
147+
value: false
148+
# setting to false to speed up testing of deploy
148149
- name: vulnerability_scan_report
149150
value: "target/dependency-check-report.html"
150151
- name: vulnerability_scan_api_key
@@ -240,7 +241,8 @@ stages:
240241
functional_test_artefact_path: "${{ variables.functional_test_artefact_path }}"
241242
pipeline_scripts_directory: "${{ variables.self_pipeline_scripts_dir }}"
242243
# Maven
243-
maven_untagged_test_check: false # set to false to speed up testing deploy step
244+
maven_untagged_test_check: false
245+
# set to false to speed up testing deploy step
244246
maven_cache_directory: "${{ variables.maven_cache_directory }}"
245247
maven_allowed_post_deploy_test_tags: "${{ variables.maven_allowed_post_deploy_test_tags }}"
246248
maven_ignored_post_deploy_test_tags: "${{ variables.maven_ignored_post_deploy_test_tags }}"

‎build/azDevOps/azure/templates/steps/build/build-java.yml

Lines changed: 66 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -89,70 +89,69 @@ steps:
8989
container: ${{ parameters.docker_build_container }}
9090
displayName: "Maven: Compile Application (${{ parameters.project_type }})"
9191

92-
# - task: Bash@3
93-
# inputs:
94-
# filePath: "${{ parameters.pipeline_scripts_directory }}/test-maven-download-test-deps.bash"
95-
# arguments: >
96-
# -X "${{ parameters.maven_allowed_test_tags }}"
97-
# -Y "${{ parameters.maven_surefire_reports_dir }}"
98-
# -Z "${{ parameters.maven_cache_directory }}"
99-
# workingDirectory: "${{ parameters.project_root_dir }}"
100-
# target:
101-
# container: ${{ parameters.docker_build_container }}
102-
# displayName: "Test: Download Test Deps (${{ parameters.project_type }})"
103-
#
104-
# - task: Bash@3
105-
# inputs:
106-
# filePath: "${{ parameters.pipeline_scripts_directory }}/test-maven-tagged-test-run.bash"
107-
# arguments: >
108-
# -a "Unit"
109-
# -Z "${{ parameters.maven_cache_directory }}"
110-
# workingDirectory: "${{ parameters.project_root_dir }}"
111-
# target:
112-
# container: ${{ parameters.docker_build_container }}
113-
# displayName: "Test: Unit tests (${{ parameters.project_type }})"
114-
#
115-
# - task: Bash@3
116-
# inputs:
117-
# filePath: "${{ parameters.pipeline_scripts_directory }}/test-maven-tagged-test-run.bash"
118-
# arguments: >
119-
# -a "Component"
120-
# -Z "${{ parameters.maven_cache_directory }}"
121-
# workingDirectory: "${{ parameters.project_root_dir }}"
122-
# target:
123-
# container: ${{ parameters.docker_build_container }}
124-
# displayName: "Test: Component tests (${{ parameters.project_type }})"
125-
#
126-
# - task: Bash@3
127-
# inputs:
128-
# filePath: "${{ parameters.pipeline_scripts_directory }}/test-maven-tagged-test-run.bash"
129-
# arguments: >
130-
# -a "Integration"
131-
# -Z "${{ parameters.maven_cache_directory }}"
132-
# workingDirectory: "${{ parameters.project_root_dir }}"
133-
# target:
134-
# container: ${{ parameters.docker_build_container }}
135-
# displayName: "Test: Integration tests (${{ parameters.project_type }})"
136-
#
137-
# - task: Bash@3
138-
# inputs:
139-
# filePath: "${{ parameters.pipeline_scripts_directory }}/test-maven-generate-jacoco-report.bash"
140-
# arguments: >
141-
# -Z "${{ parameters.maven_cache_directory }}"
142-
# workingDirectory: "${{ parameters.project_root_dir }}"
143-
# target:
144-
# container: ${{ parameters.docker_build_container }}
145-
# displayName: "Generate Jacoco coverage reports (${{ parameters.project_type }})"
146-
#
147-
# # TODO: Pull this out into a bash script?
148-
# - bash: |
149-
# set -euxo pipefail
150-
# cp "${{ parameters.repo_root_dir }}/build/azDevOps/azure/coverage/"* .
151-
# npm i
152-
# ./node_modules/.bin/gulp inline-css-images
153-
# ./node_modules/.bin/gulp inline-sources
154-
# workingDirectory: "${{ parameters.project_root_dir }}/target/site/"
155-
# target:
156-
# container: node
157-
# displayName: "Gulp: Inline Jacoco report assets (${{ parameters.project_type }})"
158-
#
92+
# - task: Bash@3
93+
# inputs:
94+
# filePath: "${{ parameters.pipeline_scripts_directory }}/test-maven-download-test-deps.bash"
95+
# arguments: >
96+
# -X "${{ parameters.maven_allowed_test_tags }}"
97+
# -Y "${{ parameters.maven_surefire_reports_dir }}"
98+
# -Z "${{ parameters.maven_cache_directory }}"
99+
# workingDirectory: "${{ parameters.project_root_dir }}"
100+
# target:
101+
# container: ${{ parameters.docker_build_container }}
102+
# displayName: "Test: Download Test Deps (${{ parameters.project_type }})"
103+
#
104+
# - task: Bash@3
105+
# inputs:
106+
# filePath: "${{ parameters.pipeline_scripts_directory }}/test-maven-tagged-test-run.bash"
107+
# arguments: >
108+
# -a "Unit"
109+
# -Z "${{ parameters.maven_cache_directory }}"
110+
# workingDirectory: "${{ parameters.project_root_dir }}"
111+
# target:
112+
# container: ${{ parameters.docker_build_container }}
113+
# displayName: "Test: Unit tests (${{ parameters.project_type }})"
114+
#
115+
# - task: Bash@3
116+
# inputs:
117+
# filePath: "${{ parameters.pipeline_scripts_directory }}/test-maven-tagged-test-run.bash"
118+
# arguments: >
119+
# -a "Component"
120+
# -Z "${{ parameters.maven_cache_directory }}"
121+
# workingDirectory: "${{ parameters.project_root_dir }}"
122+
# target:
123+
# container: ${{ parameters.docker_build_container }}
124+
# displayName: "Test: Component tests (${{ parameters.project_type }})"
125+
#
126+
# - task: Bash@3
127+
# inputs:
128+
# filePath: "${{ parameters.pipeline_scripts_directory }}/test-maven-tagged-test-run.bash"
129+
# arguments: >
130+
# -a "Integration"
131+
# -Z "${{ parameters.maven_cache_directory }}"
132+
# workingDirectory: "${{ parameters.project_root_dir }}"
133+
# target:
134+
# container: ${{ parameters.docker_build_container }}
135+
# displayName: "Test: Integration tests (${{ parameters.project_type }})"
136+
#
137+
# - task: Bash@3
138+
# inputs:
139+
# filePath: "${{ parameters.pipeline_scripts_directory }}/test-maven-generate-jacoco-report.bash"
140+
# arguments: >
141+
# -Z "${{ parameters.maven_cache_directory }}"
142+
# workingDirectory: "${{ parameters.project_root_dir }}"
143+
# target:
144+
# container: ${{ parameters.docker_build_container }}
145+
# displayName: "Generate Jacoco coverage reports (${{ parameters.project_type }})"
146+
#
147+
# # TODO: Pull this out into a bash script?
148+
# - bash: |
149+
# set -euxo pipefail
150+
# cp "${{ parameters.repo_root_dir }}/build/azDevOps/azure/coverage/"* .
151+
# npm i
152+
# ./node_modules/.bin/gulp inline-css-images
153+
# ./node_modules/.bin/gulp inline-sources
154+
# workingDirectory: "${{ parameters.project_root_dir }}/target/site/"
155+
# target:
156+
# container: node
157+
# displayName: "Gulp: Inline Jacoco report assets (${{ parameters.project_type }})"

0 commit comments

Comments
 (0)