fix: download to known location, don't dl 4 infra

Author: ElvenSpellmaker

build/azDevOps/azure/azure-pipelines-javaspring-k8s.yml

@@ -382,6 +382,8 @@ stages:
           runOnce:
             deploy:
               steps:
+                - download: none
+
                 - checkout: self
 
                 - checkout: templates

build/azDevOps/azure/templates/steps/build/build-java.yml

@@ -34,7 +34,8 @@ steps:
             HOUR="$(date "+%H")"
 
             # NVD Cache lasts 4 hours (240 mins) and so cache based on the hour's time
-            # in 24 hours. E.g. 0-3 are 0, 1-4 are 1, 20-23 are 5 etc..
+            # in 24 hours. E.g. 0-3 are 0, 1-4 are 1, 20-23 are 5 etc.. This gives a
+            # cache that lasts roughly 4 hours at a time.
             HOUR_BY_FOUR="$(( ${HOUR} / 4 ))"
 
             NVD_CACHE_FILE="${DATE}-${HOUR_BY_FOUR}"

build/azDevOps/azure/templates/steps/deploy/deploy-post-deploy-tests-karate.yml

@@ -16,6 +16,7 @@ steps:
       # $(BUILD_ATTEMPT_NUMBER) comes from the Stage Variables and is an output from the ApiBuild job
       - download: current
         artifact: "${{ parameters.functional_test_artefact_name }}-$(BUILD_ATTEMPT_NUMBER)"
+        targetPath: ${{ parameters.functional_test_artefact_name }}
         displayName: "Download: Post-Deploy Test Artefacts"
 
       # Files downloaded from artefacts seem to lose their permissions...

build/azDevOps/azure/templates/steps/deploy/deploy-post-deploy-tests-serenity.yml

@@ -16,6 +16,7 @@ steps:
       # $(BUILD_ATTEMPT_NUMBER) comes from the Stage Variables and is an output from the ApiBuild job
       - download: current
         artifact: "${{ parameters.functional_test_artefact_name }}-$(BUILD_ATTEMPT_NUMBER)"
+        targetPath: ${{ parameters.functional_test_artefact_name }}
         displayName: "Download: Post-Deploy Test Artefacts"
 
       # Files downloaded from artefacts seem to lose their permissions...