Skip to content

Commit 7b6b682

Browse files
authored
Reduce warnings (rust-lang#500)
1 parent 8ed897f commit 7b6b682

File tree

4 files changed

+31
-6
lines changed

4 files changed

+31
-6
lines changed

enzyme/Enzyme/AdjointGenerator.h

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,7 @@ class AdjointGenerator
337337
addToDiffe(orig_op0, dif1, Builder2, TR.addingType(size, orig_op0));
338338
return;
339339
}
340+
case DerivativeMode::ForwardModeSplit:
340341
case DerivativeMode::ForwardMode: {
341342
IRBuilder<> BuilderZ(&inst);
342343
getForwardBuilder(BuilderZ);
@@ -383,6 +384,7 @@ class AdjointGenerator
383384
dif1->getType()->getScalarType());
384385
break;
385386
}
387+
case DerivativeMode::ForwardModeSplit:
386388
case DerivativeMode::ForwardMode: {
387389
IRBuilder<> Builder2(&inst);
388390
getForwardBuilder(Builder2);
@@ -482,6 +484,7 @@ class AdjointGenerator
482484
}
483485
break;
484486
}
487+
case DerivativeMode::ForwardModeSplit:
485488
case DerivativeMode::ForwardMode: {
486489
newip = gutils->invertPointerM(&I, BuilderZ);
487490
assert(newip->getType() == type);
@@ -605,6 +608,7 @@ class AdjointGenerator
605608
if (isfloat) {
606609

607610
switch (Mode) {
611+
case DerivativeMode::ForwardModeSplit:
608612
case DerivativeMode::ForwardMode: {
609613
IRBuilder<> Builder2(&I);
610614
getForwardBuilder(Builder2);
@@ -889,6 +893,7 @@ class AdjointGenerator
889893
}
890894
break;
891895
}
896+
case DerivativeMode::ForwardModeSplit:
892897
case DerivativeMode::ForwardMode: {
893898
IRBuilder<> Builder2(&I);
894899
getForwardBuilder(Builder2);
@@ -1056,6 +1061,7 @@ class AdjointGenerator
10561061

10571062
break;
10581063
}
1064+
case DerivativeMode::ForwardModeSplit:
10591065
case DerivativeMode::ForwardMode: {
10601066
IRBuilder<> Builder2(&I);
10611067
getForwardBuilder(Builder2);
@@ -1096,6 +1102,7 @@ class AdjointGenerator
10961102
createSelectInstAdjoint(SI);
10971103
return;
10981104
}
1105+
case DerivativeMode::ForwardModeSplit:
10991106
case DerivativeMode::ForwardMode: {
11001107
createSelectInstDual(SI);
11011108
return;
@@ -1247,6 +1254,7 @@ class AdjointGenerator
12471254
return;
12481255

12491256
switch (Mode) {
1257+
case DerivativeMode::ForwardModeSplit:
12501258
case DerivativeMode::ForwardMode: {
12511259
IRBuilder<> Builder2(&EEI);
12521260
getForwardBuilder(Builder2);
@@ -1304,6 +1312,7 @@ class AdjointGenerator
13041312
return;
13051313

13061314
switch (Mode) {
1315+
case DerivativeMode::ForwardModeSplit:
13071316
case DerivativeMode::ForwardMode: {
13081317
IRBuilder<> Builder2(&IEI);
13091318
getForwardBuilder(Builder2);
@@ -1387,6 +1396,7 @@ class AdjointGenerator
13871396
return;
13881397

13891398
switch (Mode) {
1399+
case DerivativeMode::ForwardModeSplit:
13901400
case DerivativeMode::ForwardMode: {
13911401
IRBuilder<> Builder2(&SVI);
13921402
getForwardBuilder(Builder2);
@@ -1475,6 +1485,7 @@ class AdjointGenerator
14751485
return;
14761486

14771487
switch (Mode) {
1488+
case DerivativeMode::ForwardModeSplit:
14781489
case DerivativeMode::ForwardMode: {
14791490
IRBuilder<> Builder2(&EVI);
14801491
getForwardBuilder(Builder2);
@@ -3453,6 +3464,7 @@ class AdjointGenerator
34533464
}
34543465
return;
34553466
}
3467+
case DerivativeMode::ForwardModeSplit:
34563468
case DerivativeMode::ForwardMode: {
34573469

34583470
IRBuilder<> Builder2(&I);
@@ -7237,6 +7249,7 @@ class AdjointGenerator
72377249
return;
72387250

72397251
switch (Mode) {
7252+
case DerivativeMode::ForwardModeSplit:
72407253
case DerivativeMode::ForwardMode: {
72417254
IRBuilder<> Builder2(&call);
72427255
getForwardBuilder(Builder2);
@@ -7296,6 +7309,7 @@ class AdjointGenerator
72967309
return;
72977310

72987311
switch (Mode) {
7312+
case DerivativeMode::ForwardModeSplit:
72997313
case DerivativeMode::ForwardMode: {
73007314
IRBuilder<> Builder2(&call);
73017315
getForwardBuilder(Builder2);
@@ -7338,6 +7352,7 @@ class AdjointGenerator
73387352
return;
73397353

73407354
switch (Mode) {
7355+
case DerivativeMode::ForwardModeSplit:
73417356
case DerivativeMode::ForwardMode: {
73427357
IRBuilder<> Builder2(&call);
73437358
getForwardBuilder(Builder2);
@@ -7402,6 +7417,7 @@ class AdjointGenerator
74027417
return;
74037418

74047419
switch (Mode) {
7420+
case DerivativeMode::ForwardModeSplit:
74057421
case DerivativeMode::ForwardMode: {
74067422
IRBuilder<> Builder2(&call);
74077423
getForwardBuilder(Builder2);
@@ -7455,6 +7471,7 @@ class AdjointGenerator
74557471
return;
74567472

74577473
switch (Mode) {
7474+
case DerivativeMode::ForwardModeSplit:
74587475
case DerivativeMode::ForwardMode: {
74597476
IRBuilder<> Builder2(&call);
74607477
getForwardBuilder(Builder2);
@@ -7505,6 +7522,7 @@ class AdjointGenerator
75057522
return;
75067523

75077524
switch (Mode) {
7525+
case DerivativeMode::ForwardModeSplit:
75087526
case DerivativeMode::ForwardMode: {
75097527
IRBuilder<> Builder2(&call);
75107528
getForwardBuilder(Builder2);
@@ -7828,6 +7846,7 @@ class AdjointGenerator
78287846
return;
78297847

78307848
switch (Mode) {
7849+
case DerivativeMode::ForwardModeSplit:
78317850
case DerivativeMode::ForwardMode: {
78327851
IRBuilder<> Builder2(&call);
78337852
getForwardBuilder(Builder2);
@@ -7884,6 +7903,7 @@ class AdjointGenerator
78847903
return;
78857904

78867905
switch (Mode) {
7906+
case DerivativeMode::ForwardModeSplit:
78877907
case DerivativeMode::ForwardMode: {
78887908
IRBuilder<> Builder2(&call);
78897909
getForwardBuilder(Builder2);
@@ -7964,6 +7984,7 @@ class AdjointGenerator
79647984
return;
79657985

79667986
switch (Mode) {
7987+
case DerivativeMode::ForwardModeSplit:
79677988
case DerivativeMode::ForwardMode: {
79687989
IRBuilder<> Builder2(&call);
79697990
getForwardBuilder(Builder2);
@@ -8124,6 +8145,7 @@ class AdjointGenerator
81248145
}
81258146

81268147
switch (Mode) {
8148+
case DerivativeMode::ForwardModeSplit:
81278149
case DerivativeMode::ForwardMode: {
81288150
IRBuilder<> Builder2(&call);
81298151
getForwardBuilder(Builder2);
@@ -8199,6 +8221,7 @@ class AdjointGenerator
81998221
}
82008222

82018223
switch (Mode) {
8224+
case DerivativeMode::ForwardModeSplit:
82028225
case DerivativeMode::ForwardMode: {
82038226
IRBuilder<> Builder2(&call);
82048227
getForwardBuilder(Builder2);
@@ -8282,6 +8305,7 @@ class AdjointGenerator
82828305
}
82838306

82848307
switch (Mode) {
8308+
case DerivativeMode::ForwardModeSplit:
82858309
case DerivativeMode::ForwardMode: {
82868310
IRBuilder<> Builder2(&call);
82878311
getForwardBuilder(Builder2);
@@ -8348,12 +8372,10 @@ class AdjointGenerator
83488372
Mode == DerivativeMode::ReverseModePrimal) {
83498373

83508374
bool backwardsShadow = false;
8351-
bool forwardsShadow = true;
83528375
{
83538376
auto found = gutils->backwardsOnlyShadows.find(orig);
83548377
if (found != gutils->backwardsOnlyShadows.end()) {
83558378
backwardsShadow = true;
8356-
forwardsShadow = found->second.second;
83578379
}
83588380
}
83598381

enzyme/Enzyme/Enzyme.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,9 +449,9 @@ class Enzyme : public ModulePass {
449449

450450
// determine width
451451
#if LLVM_VERSION_MAJOR >= 14
452-
for (auto [i, found] = std::tuple{0, false}; i < CI->arg_size(); ++i)
452+
for (auto [i, found] = std::tuple{0u, false}; i < CI->arg_size(); ++i)
453453
#else
454-
for (auto [i, found] = std::tuple{0, false}; i < CI->getNumArgOperands();
454+
for (auto [i, found] = std::tuple{0u, false}; i < CI->getNumArgOperands();
455455
++i)
456456
#endif
457457
{
@@ -520,6 +520,7 @@ class Enzyme : public ModulePass {
520520

521521
Value *shadow;
522522
switch (mode) {
523+
case DerivativeMode::ForwardModeSplit:
523524
case DerivativeMode::ForwardMode: {
524525
Value *sretPt = CI->getArgOperand(0);
525526
if (width > 1) {

enzyme/Enzyme/GradientUtils.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3073,8 +3073,8 @@ Value *GradientUtils::invertPointerM(Value *const oval, IRBuilder<> &BuilderM,
30733073
}
30743074
#endif
30753075
memset->addParamAttr(0, Attribute::NonNull);
3076-
assert(width > 1 && antialloca->getType() ==
3077-
ArrayType::get(arg->getType(), width) ||
3076+
assert((width > 1 && antialloca->getType() ==
3077+
ArrayType::get(arg->getType(), width)) ||
30783078
antialloca->getType() == arg->getType());
30793079
return antialloca;
30803080
};

enzyme/Enzyme/GradientUtils.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,9 @@ class GradientUtils : public CacheUtility {
627627
idx++;
628628
continue;
629629
}
630+
#if LLVM_VERSION_MAJOR <= 7
630631
auto F = CI->getCalledFunction();
632+
#endif
631633
auto TT = TR.query(prev)[{-1, -1}];
632634
// If it either could capture, or could have a int/pointer written to
633635
// it it is not promotable

0 commit comments

Comments
 (0)