Update app/Models/PeriodicEvent.php

kdmnk · coderabbitai[bot] · web-flow · commit 58a6574070ea · 2024-05-19T21:19:24.000+02:00
Co-authored-by: coderabbitai[bot] &lt;136622811+coderabbitai[bot]@users.noreply.github.com&gt;
diff --git a/app/Models/PeriodicEvent.php b/app/Models/PeriodicEvent.php
@@ -101,13 +101,7 @@ public function deadline(): ?Carbon
      */
     public function isActive(): bool
     {
-        if ($this->startDate()->isFuture()) {
-            return false;
-        }
-        if ($this->endDate()->isPast()) {
-            return false;
-        }
-        return true;
+        return !$this->startDate()->isFuture() && !$this->endDate()->isPast();
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -101,13 +101,7 @@ public function deadline(): ?Carbon`
`101`	`101`	`*/`
`102`	`102`	`public function isActive(): bool`
`103`	`103`	`{`
`104`		`- if ($this->startDate()->isFuture()) {`
`105`		`- return false;`
`106`		`- }`
`107`		`- if ($this->endDate()->isPast()) {`
`108`		`- return false;`
`109`		`- }`
`110`		`- return true;`
	`104`	`+ return !$this->startDate()->isFuture() && !$this->endDate()->isPast();`
`111`	`105`	`}`
`112`	`106`
`113`	`107`	`/**`