Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: FriendsOfSymfony1/symfony1
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.5.15
Choose a base ref
...
head repository: FriendsOfSymfony1/symfony1
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.5.16
Choose a head ref

Commits on Jan 12, 2023

  1. Copy the full SHA
    31d2c60 View commit details

Commits on Jan 13, 2023

  1. Fix(deprecations) Fix deprecations in sfMessageSource_Aggregate (#277)

    * Fix(deprecations) Fix deprecations in sfMessageSource_Aggregate, add return types from implemented sfIMessageSource
    thePanz authored Jan 13, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2c5a4d6 View commit details

Commits on Feb 22, 2023

  1. Copy the full SHA
    ffbbce6 View commit details
  2. Copy the full SHA
    2cbd557 View commit details

Commits on Mar 9, 2023

  1. Copy the full SHA
    dc824de View commit details

Commits on Nov 17, 2023

  1. Fix: avoid creating dynamic property $options in sfViewCacheManager (#…

    …290)
    
    Dynamic properties are deprecated since PHP8.2
    vimar authored Nov 17, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    3c59273 View commit details
  2. Copy the full SHA
    ef9f881 View commit details
  3. Copy the full SHA
    2826410 View commit details

Commits on Dec 18, 2023

  1. add php8.3

    connorhu authored and thePanz committed Dec 18, 2023
    Copy the full SHA
    8ba3ff2 View commit details
  2. Copy the full SHA
    2a68033 View commit details

Commits on Dec 30, 2023

  1. Copy the full SHA
    21c70f1 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    1fe8979 View commit details

Commits on Jan 3, 2024

  1. Fix APC cache tests

    - Using negative TTLs to force the immediate expiration of keys, while
      convenient in tests, doesn't work consistently with APC and is an
      undocumented feature. Using a low TTL and sleep() is what guarantees
      that it works for APC. See krakjoe/apcu#184
    
    - The setting apc.use_request_time interferes with key expiration when
      running on the CLI. Making sure it always has a sensible value for
      running the tests. See krakjoe/apcu#392
    mentalstring authored and thePanz committed Jan 3, 2024
    Copy the full SHA
    be784fc View commit details
  2. Add APCu support

    Support for the APCu extension (through sfAPCuCache) as an alternative
    to APC, which no longer works with recent versions of PHP.
    mentalstring authored and thePanz committed Jan 3, 2024
    Copy the full SHA
    1d14219 View commit details
  3. Fix sfCacheSessionStorageTest with PHP>=7.2

    From PHP 7.2 onward, session functions are stricter and may not work
    if output/headers have already been sent out. Using output buffering
    prevents this issue.
    mentalstring authored and thePanz committed Jan 3, 2024
    Copy the full SHA
    5615daa View commit details
  4. Remove test dependency on APC

    Replace the use of sfAPCCache with sfFileCache in
    sfCacheSessionStorageTest so that it doesn't depend on APC being
    available.
    mentalstring authored and thePanz committed Jan 3, 2024
    Copy the full SHA
    5837057 View commit details
  5. Fix deprecation on stropos() usage on sfDebug::shortenFilePath (#299)

    Fix PHP v8.x deprecation on strpos() usage with `null` as first parameter
    iricketson authored Jan 3, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    1446798 View commit details
  6. Copy the full SHA
    57758f5 View commit details
  7. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    d1dc877 View commit details
  8. Copy the full SHA
    6edd425 View commit details

Commits on Jan 11, 2024

  1. Declare $params var

    iricketson committed Jan 11, 2024
    Copy the full SHA
    806ce84 View commit details
  2. Replace default with 0

    iricketson committed Jan 11, 2024
    Copy the full SHA
    d60c2c1 View commit details

Commits on Jan 14, 2024

  1. Merge pull request #307 from iricketson/fix/sfValidatorIp

    [PHP] Replace default $flags variable with 0
    connorhu authored Jan 14, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    d0f559c View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    f19a707 View commit details
  3. Merge pull request #306 from iricketson/fix/sfDoctrineFormGenerator

    [PHP8] Declare sfDoctrineFormGenerator $params property
    connorhu authored Jan 14, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    abdbd74 View commit details

Commits on Jan 17, 2024

  1. Update README

    Fix build badge, update supported PHP version and other minor tweaks.
    mentalstring authored and thePanz committed Jan 17, 2024
    Copy the full SHA
    66e79cf View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    424ed4d View commit details
  3. Copy the full SHA
    9d26d67 View commit details
  4. Fix PHP8.1 sfForm - Unsupported operand types: array + null on sfForm…

    …::updateValues()
    
    Avoid error:
    Fatal error: Uncaught TypeError: Unsupported operand types: array + null in lib\form\sfForm.class.php:319
    
    Step to reproduce :
    $form = new sfForm();
    $form->updateValues(array('foo' => 'value'));
    
    PHP 5.3 coding style
    
    May use sfForm::getValues(), but as sfForm::updateValues() is a hack, it could be used before bind ($this->isBound = true);
    Tybaze authored and thePanz committed Jan 17, 2024
    Copy the full SHA
    b88d698 View commit details

Commits on Jan 18, 2024

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    2a15114 View commit details
  2. Merge pull request #311 from FriendsOfSymfony1/fix-link-to-github-pip…

    …eline-badge
    
    Fix link to GitHub pipeline badge
    connorhu authored Jan 18, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    d90dc72 View commit details
  3. Copy the full SHA
    e6e9f94 View commit details

Commits on Jan 19, 2024

  1. fix(phpdoc) remove version tag

    connorhu authored and thePanz committed Jan 19, 2024
    Copy the full SHA
    6354fd3 View commit details

Commits on Feb 7, 2024

  1. PHP 8.3 deprecated errors fixed (#320)

    miamibc authored and thePanz committed Feb 7, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    thePanz Emanuele Panzeri
    Copy the full SHA
    55a02ab View commit details
Showing 942 changed files with 66,862 additions and 73,706 deletions.
File renamed without changes.
6 changes: 5 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
@@ -2,11 +2,15 @@ root = true

[*]
indent_style = space
indent_size = 2
indent_size = 4
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.md]
trim_trailing_whitespace = false

[.github/**.yml]
indent_size = 2
indent_style = space
6 changes: 0 additions & 6 deletions .env.dist
Original file line number Diff line number Diff line change
@@ -3,9 +3,3 @@
#
# Copy to `.env` in order to use it.
#

# APC test are disabled.
#
# To enable them in order to provide a fix, set to "on".
#
APC_ENABLE_CLI=off
11 changes: 11 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
.docker/ export-ignore
.editorconfig export-ignore
.env.dist export-ignore
.gitattributes export-ignore
.github/ export-ignore
.gitignore export-ignore
.php-cs-fixer.dist.php export-ignore
docker-compose.yml export-ignore
phpstan.neon export-ignore
phpunit.xml export-ignore
tests/ export-ignore
98 changes: 56 additions & 42 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
@@ -1,49 +1,63 @@
name: "Continuous Integration"

on:
push:
branches:
- master
pull_request:
push:
branches:
- master
pull_request:

env:
fail-fast: true
fail-fast: true

jobs:
tests:
name: "Symfony1 Tests"
runs-on: "ubuntu-22.04"

strategy:
matrix:
php-version:
- "7.4"
- "8.0"
- "8.1"
- "8.2"
memcached-version:
- "1.6"

services:
memcached:
image: "memcached:${{ matrix.memcached-version }}"

steps:
- name: "Checkout"
uses: "actions/checkout@v3"
with:
submodules: "true"

- name: "Install PHP"
uses: "shivammathur/setup-php@v2"
with:
php-version: "${{ matrix.php-version }}"

- name: "Install dependencies with Composer"
uses: "ramsey/composer-install@v2"

- name: "Run Check configuration"
run: "php data/bin/check_configuration.php"

- name: "Run Tests"
run: "php data/bin/symfony symfony:test --trace"
tests:
name: "Symfony1 Tests"
runs-on: "ubuntu-latest"

strategy:
matrix:
php-version:
- "7.4"
- "8.0"
- "8.1"
- "8.2"
- "8.3"
memcached-version:
- "1.6"

services:
memcached:
image: "memcached:${{ matrix.memcached-version }}"

steps:
- name: Checkout
uses: actions/checkout@v3
with:
submodules: "true"

- name: Install PHP
uses: shivammathur/setup-php@v2
with:
php-version: "${{ matrix.php-version }}"
extensions: apcu
ini-values: apc.enable_cli=1

- name: Get composer cache directory
id: composer-cache
run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT

- name: Cache dependencies
uses: actions/cache@v3
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
restore-keys: ${{ runner.os }}-composer-

- name: Install dependencies
run: composer install --prefer-dist

- name: Run Check configuration
run: php data/bin/check_configuration.php

- name: Run Tests
run: php data/bin/symfony symfony:test --trace
31 changes: 31 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: "Code Linting"
on:
push:
branches:
- master
pull_request:

jobs:
php-cs-fixer:
name: 'PHP-CS-Fixer'
runs-on: 'ubuntu-latest'
steps:
- uses: actions/checkout@v3

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.2
tools: php-cs-fixer:3.45, cs2pr

- uses: actions/cache@v3
with:
path: '.php-cs-fixer.cache'
key: ${{ github.repository }}-8.2-phpcsfixer-${{ github.ref_name }}
restore-keys: |
${{ github.repository }}-8.2-phpcsfixer-master
${{ github.repository }}-8.2-phpcsfixer-
- name: Run PHP-CS-Fixer
# Using cs2pr settings, see: https://github.com/shivammathur/setup-php#tools-with-checkstyle-support
run: 'php-cs-fixer fix --dry-run --format checkstyle | cs2pr'
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -6,3 +6,4 @@
lib/plugins/sfDoctrinePlugin/test/functional/fixtures/log/
/vendor
/composer.lock
.php-cs-fixer.cache
29 changes: 29 additions & 0 deletions .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php

$finder = PhpCsFixer\Finder::create()
->ignoreVCSIgnored(true)
->in(__DIR__.'/lib')
->in(__DIR__.'/data/bin')
->in(__DIR__.'/test')
->append(array(__FILE__))
// Exclude PHP classes templates/generators, which are not valid PHP files
->exclude('task/generator/skeleton/')
->exclude('plugins/sfDoctrinePlugin/data/generator/')
// Exclude generated files (single files)
->notPath('unit/config/fixtures/sfDefineEnvironmentConfigHandler/prefix_result.php')
->notPath('unit/config/fixtures/sfFilterConfigHandler/result.php')
;

$config = new PhpCsFixer\Config();
$config->setRules(array(
'@PhpCsFixer' => true,
'@Symfony' => true,
'array_syntax' => array(
'syntax' => 'long',
),
))
->setCacheFile('.php-cs-fixer.cache')
->setFinder($finder)
;

return $config;
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
CHANGELOG
=========

=======
xx/xx/xxxx: Version 1.5.16
--------------------------


12/01/2023: Version 1.5.15
--------------------------

22 changes: 11 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
[![Build Status](https://secure.travis-ci.org/FriendsOfSymfony1/symfony1.png?branch=master)](http://travis-ci.org/FriendsOfSymfony1/symfony1)
![Build Status](https://github.com/FriendsOfSymfony1/symfony1/actions/workflows/continuous-integration.yml/badge.svg)

About this version
------------------

This is a community driven fork of symfony 1, as official support has been [interrupted in November 2012](http://symfony.com/blog/symfony-1-4-end-of-maintenance-what-does-it-mean).
This is a community driven fork of symfony 1, as official support has been [interrupted in November 2012](https://symfony.com/blog/symfony-1-4-end-of-maintenance-what-does-it-mean).

**Do not use it for new projects: this version is great to improve existing symfony1 applications, but [Symfony5](http://symfony.com/) is the way to go today.**
**Do not use it for new projects: this version is great to improve existing symfony1 applications, but [newer Symfony](https://symfony.com/) versions is the way to go today.**

All the enhancements and BC breaks are listed in the [WHATS_NEW](https://github.com/FriendsOfSymfony1/symfony1/blob/master/WHATS_NEW.md) file, this include:

- [DIC](https://github.com/FriendsOfSymfony1/symfony1/wiki/ServiceContainer)
- Composer support
- PHP 8.2 support
- PHP 8.3 support
- performance boost
- new widgets & validators
- some tickets fixed from the symfony trac
@@ -34,22 +34,22 @@ It runs on *nix and Windows platforms*.
Requirements
------------

PHP 5.3.4 and up. See prerequisites on http://symfony.com/legacy/doc/getting-started/1_4/en/02-Prerequisites
PHP 5.3.4 and up. See prerequisites on https://symfony.com/legacy/doc/getting-started/1_4/en/02-Prerequisites

Installation
------------

See http://symfony.com/legacy/doc/getting-started/1_4/en/03-Symfony-Installation
See https://symfony.com/legacy/doc/getting-started/1_4/en/03-Symfony-Installation

Option 1: Using [Composer](http://getcomposer.org/doc/00-intro.md) as dependency management:
Option 1: Using [Composer](https://getcomposer.org/doc/00-intro.md) as dependency management:

composer require friendsofsymfony1/symfony1 "1.5.*"
composer install
Note: On windows, if your project is a few directories down from the drive root, composer can throw an error relating to ZipArchive::extractTo(), this can be because pathnames are too long. There currently appears to be no proper solution but a workaround is to move your project to the drive root, run the commands from there, where they will run happily, and then move your project back.

Note: On windows, if your project is a few directories down from the drive root, composer can throw an error relating to ZipArchive::extractTo(), this can be because pathnames are too long. There currently appears to be no proper solution but a workaround is to move your project to the drive root, run the commands from there, where they will run happily, and then move your project back.

Option 2: Using Git submodules:

git init # your project
git submodule add https://github.com/FriendsOfSymfony1/symfony1.git lib/vendor/symfony
git submodule update --init --recursive
@@ -88,7 +88,7 @@ Tests
Documentation
-------------

Read the official [symfony1 documentation](http://symfony.com/legacy)
Read the official [symfony1 documentation](https://symfony.com/legacy)

Contributing
------------
31 changes: 15 additions & 16 deletions data/bin/changelog.php
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
/*
* This file is part of the symfony package.
* (c) Fabien Potencier <fabien.potencier@symfony-project.com>
*
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
@@ -13,22 +13,22 @@
*
* Usage: php data/bin/changelog.php -r12345:67890 /branches/1.3
*
* @package symfony
* @author Fabien Potencier <fabien.potencier@symfony-project.com>
*
* @version SVN: $Id$
*/
require_once __DIR__.'/../../lib/task/sfFilesystem.class.php';

if (!isset($argv[1]))
{
echo "You must provide a revision range (-r123:456)\n";
exit(1);
if (!isset($argv[1])) {
echo "You must provide a revision range (-r123:456)\n";

exit(1);
}

if (!isset($argv[2]))
{
echo "You must provide a repository path (/branches/1.4)\n";
exit(1);
if (!isset($argv[2])) {
echo "You must provide a repository path (/branches/1.4)\n";

exit(1);
}

$filesystem = new sfFilesystem();
@@ -37,13 +37,12 @@
$info = new SimpleXMLElement($out);

list($out, $err) = $filesystem->execute(vsprintf('svn log %s --xml %s', array_map('escapeshellarg', array(
$argv[1],
(string) $info->entry->repository->root.$argv[2],
$argv[1],
(string) $info->entry->repository->root.$argv[2],
))));
$log = new SimpleXMLElement($out);

foreach ($log->logentry as $logentry)
{
echo sprintf(' * [%d] %s', $logentry['revision'], trim(preg_replace('/\s*\[[\d\., ]+\]\s*/', '', (string) $logentry->msg)));
echo PHP_EOL;
foreach ($log->logentry as $logentry) {
echo sprintf(' * [%d] %s', $logentry['revision'], trim(preg_replace('/\s*\[[\d\., ]+\]\s*/', '', (string) $logentry->msg)));
echo PHP_EOL;
}
Loading