fix trakt import fails if season not found in TMDB #528

Author: FuzzyGrim

src/app/providers/tmdb.py

@@ -212,7 +212,9 @@ def tv_with_seasons(media_id, season_numbers):
                 # Create a new response object with 404 status
                 not_found_response = requests.Response()
                 not_found_response.status_code = 404
-                raise requests.exceptions.HTTPError(msg, response=not_found_response)
+                # Set the error attribute to match what ProviderAPIError expects
+                not_found_error = type("Error", (), {"response": not_found_response})
+                raise services.ProviderAPIError(msg, error=not_found_error, details=msg)
 
             season_data = process_season(response[season_key])
 

src/integrations/imports/simkl.py

@@ -7,6 +7,7 @@
 
 import app
 from app.models import Media, MediaTypes, Sources
+from app.providers import services
 from integrations import helpers
 from integrations.helpers import MediaImportError, MediaImportUnexpectedError
 
@@ -42,8 +43,8 @@ def get_token(request):
             headers=headers,
             params=params,
         )
-    except requests.exceptions.HTTPError as error:
-        if error.response.status_code == requests.codes.unauthorized:
+    except services.ProviderAPIError as error:
+        if error.status_code == requests.codes.unauthorized:
             msg = "Invalid SIMKL secret key."
             raise MediaImportError(msg) from error
         raise
@@ -149,8 +150,8 @@ def process_tv_list(tv_list, user, bulk_media, warnings):
 
             try:
                 metadata = app.providers.tmdb.tv_with_seasons(tmdb_id, season_numbers)
-            except requests.exceptions.HTTPError as error:
-                if error.response.status_code == requests.codes.not_found:
+            except services.ProviderAPIError as error:
+                if error.status_code == requests.codes.not_found:
                     warnings.append(
                         f"{title}: not found in {Sources.TMDB.label} "
                         f"with ID {tmdb_id}.",
@@ -295,8 +296,8 @@ def process_movie_list(movie_list, user, bulk_media, warnings):
 
             try:
                 metadata = app.providers.tmdb.movie(tmdb_id)
-            except requests.exceptions.HTTPError as error:
-                if error.response.status_code == requests.codes.not_found:
+            except services.ProviderAPIError as error:
+                if error.status_code == requests.codes.not_found:
                     warnings.append(
                         f"{title}: not found in {Sources.TMDB.label} "
                         f"with ID {tmdb_id}.",
@@ -359,8 +360,8 @@ def process_anime_list(anime_list, user, bulk_media, warnings):
 
             try:
                 metadata = app.providers.mal.anime(mal_id)
-            except requests.exceptions.HTTPError as error:
-                if error.response.status_code == requests.codes.not_found:
+            except services.ProviderAPIError as error:
+                if error.status_code == requests.codes.not_found:
                     warnings.append(
                         f"{title}: not found in {Sources.MAL.label} with ID {mal_id}.",
                     )

src/integrations/imports/yamtrack.py

@@ -1,13 +1,12 @@
 import logging
 from csv import DictReader
 
-import requests
 from django.apps import apps
 from django.conf import settings
 
 import app
-import app.providers
 from app.models import TV, Episode, MediaTypes, Season, Sources
+from app.providers import services
 from integrations import helpers
 from integrations.helpers import MediaImportError, MediaImportUnexpectedError
 
@@ -65,7 +64,7 @@ def add_bulk_media(row, user, bulk_media, warnings):
             row["image"] = settings.IMG_NONE
         else:
             try:
-                metadata = app.providers.services.get_media_metadata(
+                metadata = services.get_media_metadata(
                     media_type,
                     row["media_id"],
                     row["source"],
@@ -74,7 +73,7 @@ def add_bulk_media(row, user, bulk_media, warnings):
                 )
                 row["title"] = metadata["title"]
                 row["image"] = metadata["image"]
-            except requests.exceptions.HTTPError as e:
+            except services.ProviderAPIError as e:
                 warnings.append(
                     f"Failed to fetch metadata for {row['media_id']}: {e!s}",
                 )