Skip to content

[Enhancement]Implement new ICE restart Spec #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2025

Conversation

ipavlidakis
Copy link
Contributor

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-956/implement-new-icerestart-spec

🎯 Goal

This revision implement the ICERestart spec.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis self-assigned this Jun 25, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner June 25, 2025 12:05
@ipavlidakis ipavlidakis added the enhancement New feature or request label Jun 25, 2025
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jun 25, 2025

SDK Size

title develop branch diff status
StreamVideo 8.04 MB 8.06 MB +19 KB 🟢
StreamVideoSwiftUI 2.27 MB 2.27 MB 0 KB 🟢
StreamVideoUIKit 2.4 MB 2.4 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

Copy link

Public Interface

🚀 No changes affecting the public interface.

@ipavlidakis ipavlidakis force-pushed the enhancement/rework-reconnection-and-ice-restarts branch 2 times, most recently from 44c908d to 188eeb8 Compare June 25, 2025 14:54
Copy link

Public Interface

 @MainActor open class CallViewModel: ObservableObject  
-   public var localParticipant: CallParticipant?
+   @Published public var localParticipant: CallParticipant?

 public class StreamVideo: ObservableObject, @unchecked Sendable  
-   public func call(callType: String,callId: String,callSettings: CallSettings? = nil)-> Call
+   public func call(callType: String,callId: String,callSettings: CallSettings? = nil,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)-> Call

Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@ipavlidakis ipavlidakis force-pushed the enhancement/rework-reconnection-and-ice-restarts branch from 188eeb8 to aaa79c7 Compare June 25, 2025 20:24
Copy link

Public Interface

 @MainActor open class CallViewModel: ObservableObject  
-   public var localParticipant: CallParticipant?
+   @Published public var localParticipant: CallParticipant?

@ipavlidakis ipavlidakis force-pushed the enhancement/rework-reconnection-and-ice-restarts branch from aaa79c7 to 26adaef Compare June 26, 2025 07:36
Copy link

Public Interface

🚀 No changes affecting the public interface.

1 similar comment
Copy link

Public Interface

🚀 No changes affecting the public interface.

Copy link

Public Interface

+ public protocol TimerProviding



@ipavlidakis ipavlidakis force-pushed the enhancement/rework-reconnection-and-ice-restarts branch from ef2d0d9 to ca51681 Compare June 26, 2025 11:03
Copy link

Public Interface

🚀 No changes affecting the public interface.

@ipavlidakis ipavlidakis force-pushed the enhancement/rework-reconnection-and-ice-restarts branch from d45fa3e to 0589a29 Compare June 26, 2025 11:24
Copy link

Public Interface

🚀 No changes affecting the public interface.

Copy link

Public Interface

🚀 No changes affecting the public interface.

Copy link

@ipavlidakis ipavlidakis merged commit b5dfb8b into develop Jun 27, 2025
20 of 21 checks passed
@ipavlidakis ipavlidakis deleted the enhancement/rework-reconnection-and-ice-restarts branch June 27, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants