Skip to content
This repository was archived by the owner on May 8, 2025. It is now read-only.

Commit b147dc2

Browse files
committed
Add flinkPropertiesSecret for supporting secret properties
Resolves #383 Signed-off-by: Sunghoon Kang <[email protected]>
1 parent 0310df7 commit b147dc2

11 files changed

+676
-76
lines changed

api/v1beta1/flinkcluster_default_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@ func TestSetDefault(t *testing.T) {
110110
},
111111
SecurityContext: nil,
112112
},
113-
FlinkProperties: nil,
113+
FlinkProperties: nil,
114+
FlinkPropertiesSecret: nil,
114115
HadoopConfig: &HadoopConfig{
115116
MountPath: "/etc/hadoop/conf",
116117
},
@@ -204,7 +205,8 @@ func TestSetNonDefault(t *testing.T) {
204205
AfterJobCancelled: "KeepCluster",
205206
},
206207
},
207-
FlinkProperties: nil,
208+
FlinkProperties: nil,
209+
FlinkPropertiesSecret: nil,
208210
HadoopConfig: &HadoopConfig{
209211
MountPath: "/opt/flink/hadoop/conf",
210212
},
@@ -268,7 +270,8 @@ func TestSetNonDefault(t *testing.T) {
268270
AfterJobCancelled: "KeepCluster",
269271
},
270272
},
271-
FlinkProperties: nil,
273+
FlinkProperties: nil,
274+
FlinkPropertiesSecret: nil,
272275
HadoopConfig: &HadoopConfig{
273276
MountPath: "/opt/flink/hadoop/conf",
274277
},

api/v1beta1/flinkcluster_types.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,9 +447,12 @@ type FlinkClusterSpec struct {
447447
// TaskManager and job containers.
448448
EnvFrom []corev1.EnvFromSource `json:"envFrom,omitempty"`
449449

450-
// Flink properties which are appened to flink-conf.yaml.
450+
// Flink properties which are appended to flink-conf.yaml.
451451
FlinkProperties map[string]string `json:"flinkProperties,omitempty"`
452452

453+
// Secret source of Flink properties which will be appended to flink-conf.yaml.
454+
FlinkPropertiesSecret *corev1.SecretEnvSource `json:"flinkPropertiesSecret,omitempty"`
455+
453456
// Config for Hadoop.
454457
HadoopConfig *HadoopConfig `json:"hadoopConfig,omitempty"`
455458

api/v1beta1/zz_generated.deepcopy.go

Lines changed: 20 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)