Fixed the way roles added while creating node for testing

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

Author: vinaykpud

test/framework/src/main/java/org/opensearch/test/ClusterServiceUtils.java

@@ -57,6 +57,8 @@
 import org.opensearch.threadpool.ThreadPool;
 
 import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.atomic.AtomicReference;
 
@@ -145,11 +147,15 @@ public void onFailure(String source, Exception e) {
     }
 
     public static ClusterService createClusterService(ThreadPool threadPool) {
+        // Remove the search role since we don't expect a search role to co-exist with any other role
+        Set<DiscoveryNodeRole> nodeRoles = new HashSet<>(DiscoveryNodeRole.BUILT_IN_ROLES);
+        nodeRoles.remove(DiscoveryNodeRole.SEARCH_ROLE);
+
         DiscoveryNode discoveryNode = new DiscoveryNode(
             "node",
             OpenSearchTestCase.buildNewFakeTransportAddress(),
             Collections.emptyMap(),
-            DiscoveryNodeRole.BUILT_IN_ROLES,
+            nodeRoles,
             Version.CURRENT
         );
         return createClusterService(threadPool, discoveryNode);