Offer Additional AI preferences and update to the latest Gemini models (#15400)

* - Add preference to allow user to choose if they want to store API key for AI models
- Add preference to allow user to view API key for AI models
- Move to latest gemini models and remove deprecated models

* Add missing localization keys

* Change test to fit new model name

* Fix casing

* trigger CI

* Address review comments
- Remove view api key toggle and place toggle inside the checkbox
- Rename "Remember API key" to "Persist API key across sessions"
- Change default persist api key preference to true

* Replace Custom Password field with EnhancedPasswordField from GemsFX

* Fix conflict

* trigger CI

* Address review comments

* Remove the preference to persist API key across  restarts and revert to original behaviour.

Add a delete button in the API key field to improve UX.

---------

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

Author: ganesh-vk

CHANGELOG.md

@@ -27,6 +27,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 ### Changed
 
+- We replaced deprecated Gemini Models from the AI chat model selection and with current ones. [#15398](https://github.com/JabRef/jabref/issues/15398)
 - We changed CSL reference format by adding citation type at the end.  [#15370](https://github.com/JabRef/jabref/issues/15370) [#15434](https://github.com/JabRef/jabref/issues/15434)
 - We changed the groups filter field to use a filter icon. [#15402](https://github.com/JabRef/jabref/issues/15402)
 - We improved the MultiMergeEntries dialog to automatically select the most plausible field value when merging entries (e.g. a more specific date). [#15027](https://github.com/JabRef/jabref/issues/15027)

jabgui/src/main/java/org/jabref/gui/preferences/ai/AiTab.java

@@ -15,11 +15,13 @@
 import javafx.scene.control.TabPane;
 import javafx.scene.control.TextArea;
 import javafx.scene.control.TextField;
+import javafx.scene.layout.HBox;
 import javafx.scene.layout.VBox;
 
 import org.jabref.gui.actions.ActionFactory;
 import org.jabref.gui.actions.StandardActions;
 import org.jabref.gui.help.HelpAction;
+import org.jabref.gui.icon.IconTheme;
 import org.jabref.gui.preferences.AbstractPreferenceTabView;
 import org.jabref.gui.preferences.PreferencesTab;
 import org.jabref.gui.util.ViewModelListCellFactory;
@@ -30,14 +32,12 @@
 import org.jabref.model.ai.EmbeddingModel;
 
 import com.airhacks.afterburner.views.ViewLoader;
+import com.dlsc.gemsfx.EnhancedPasswordField;
 import com.dlsc.unitfx.IntegerInputField;
 import de.saxsys.mvvmfx.utils.validation.visualization.ControlsFxVisualizer;
 import org.controlsfx.control.SearchableComboBox;
-import org.controlsfx.control.textfield.CustomPasswordField;
 
 public class AiTab extends AbstractPreferenceTabView<AiTabViewModel> implements PreferencesTab {
-    private static final String HUGGING_FACE_CHAT_MODEL_PROMPT = "TinyLlama/TinyLlama_v1.1 (or any other model name)";
-    private static final String GPT_4_ALL_CHAT_MODEL_PROMPT = "Phi-3.1-mini (or any other local model name from GPT4All)";
 
     @FXML private CheckBox enableAi;
     @FXML private CheckBox autoGenerateEmbeddings;
@@ -50,7 +50,7 @@ public class AiTab extends AbstractPreferenceTabView<AiTabViewModel> implements
 
     @FXML private ComboBox<AiProvider> aiProviderComboBox;
     @FXML private ComboBox<String> chatModelComboBox;
-    @FXML private CustomPasswordField apiKeyTextField;
+    @FXML private EnhancedPasswordField apiKeyTextField;
 
     @FXML private CheckBox customizeExpertSettingsCheckbox;
     @FXML private VBox expertSettingsPane;
@@ -213,13 +213,27 @@ private void initializeExpertSettings() {
 
     private void initializeApiKey() {
         apiKeyTextField.textProperty().bindBidirectional(viewModel.apiKeyProperty());
+
         // Disable if GPT4ALL is selected
         apiKeyTextField.disableProperty().bind(
                 Bindings.or(
                         viewModel.disableBasicSettingsProperty(),
                         aiProviderComboBox.valueProperty().isEqualTo(AiProvider.GPT4ALL)
                 )
         );
+
+        Button revealApiKeyButton = IconTheme.JabRefIcons.PASSWORD_REVEALED.asButton();
+        revealApiKeyButton.disableProperty().bind(apiKeyTextField.disableProperty());
+        revealApiKeyButton.setOnAction(_ -> apiKeyTextField.setShowPassword(!apiKeyTextField.isShowPassword()));
+
+        Button clearApiKeyButton = IconTheme.JabRefIcons.DELETE_ENTRY.asButton();
+        clearApiKeyButton.disableProperty().bind(apiKeyTextField.disableProperty());
+        clearApiKeyButton.setOnAction(_ -> {
+            apiKeyTextField.clear();
+            apiKeyTextField.requestFocus();
+        });
+
+        apiKeyTextField.setRight(new HBox(revealApiKeyButton, clearApiKeyButton));
     }
 
     private void initializeChatModel() {
@@ -232,10 +246,10 @@ private void initializeChatModel() {
 
         this.aiProviderComboBox.valueProperty().addListener((observable, oldValue, newValue) -> {
             if (newValue == AiProvider.HUGGING_FACE) {
-                chatModelComboBox.setPromptText(HUGGING_FACE_CHAT_MODEL_PROMPT);
+                chatModelComboBox.setPromptText(Localization.lang("TinyLlama/TinyLlama_v1.1 (or any other model name)"));
             }
             if (newValue == AiProvider.GPT4ALL) {
-                chatModelComboBox.setPromptText(GPT_4_ALL_CHAT_MODEL_PROMPT);
+                chatModelComboBox.setPromptText(Localization.lang("Phi-3.1-mini (or any other local model name from GPT4All)"));
             }
         });
     }

jabgui/src/main/java/org/jabref/gui/preferences/network/NetworkTab.java

@@ -25,9 +25,9 @@
 import org.jabref.logic.l10n.Localization;
 
 import com.airhacks.afterburner.views.ViewLoader;
+import com.dlsc.gemsfx.EnhancedPasswordField;
 import com.tobiasdiez.easybind.EasyBind;
 import de.saxsys.mvvmfx.utils.validation.visualization.ControlsFxVisualizer;
-import org.controlsfx.control.textfield.CustomPasswordField;
 
 import static javafx.beans.binding.Bindings.not;
 
@@ -44,7 +44,7 @@ public class NetworkTab extends AbstractPreferenceTabView<NetworkTabViewModel> i
     @FXML private Label proxyUsernameLabel;
     @FXML private TextField proxyUsername;
     @FXML private Label proxyPasswordLabel;
-    @FXML private CustomPasswordField proxyPassword;
+    @FXML private EnhancedPasswordField proxyPassword;
     @FXML private CheckBox proxyPersistPassword;
     @FXML private SplitPane persistentTooltipWrapper; // The disabled persistPassword control does not show tooltips
     @FXML private Button checkConnectionButton;
@@ -54,7 +54,7 @@ public class NetworkTab extends AbstractPreferenceTabView<NetworkTabViewModel> i
     // endregion
 
     @FXML private TextField gitUsername;
-    @FXML private CustomPasswordField gitPat;
+    @FXML private EnhancedPasswordField gitPat;
     @FXML private CheckBox gitPersistPat;
     @FXML private SplitPane persistGitPatTooltipWrapper;
     private String gitPatText = "";
@@ -118,9 +118,9 @@ public void initialize() {
         });
 
         proxyPassword.setRight(IconTheme.JabRefIcons.PASSWORD_REVEALED.getGraphicNode());
-        proxyPassword.getRight().addEventFilter(MouseEvent.MOUSE_PRESSED, this::proxyPasswordReveal);
-        proxyPassword.getRight().addEventFilter(MouseEvent.MOUSE_RELEASED, this::proxyPasswordMask);
-        proxyPassword.getRight().addEventFilter(MouseEvent.MOUSE_EXITED, this::proxyPasswordMask);
+        proxyPassword.setOnMouseClicked(event -> {
+            proxyPassword.setShowPassword(!proxyPassword.isShowPassword());
+        });
 
         validationVisualizer.setDecoration(new IconValidationDecorator());
         Platform.runLater(() -> {
@@ -142,9 +142,9 @@ public void initialize() {
         });
 
         gitPat.setRight(IconTheme.JabRefIcons.PASSWORD_REVEALED.getGraphicNode());
-        gitPat.getRight().addEventFilter(MouseEvent.MOUSE_PRESSED, this::gitPatReveal);
-        gitPat.getRight().addEventFilter(MouseEvent.MOUSE_RELEASED, this::gitPatMask);
-        gitPat.getRight().addEventFilter(MouseEvent.MOUSE_EXITED, this::gitPatMask);
+        gitPat.setOnMouseClicked(event -> {
+            gitPat.setShowPassword(!gitPat.isShowPassword());
+        });
 
         certSerialNumber.setCellValueFactory(data -> data.getValue().serialNumberProperty());
         certIssuer.setCellValueFactory(data -> data.getValue().issuerProperty());
@@ -189,23 +189,6 @@ private void proxyPasswordMask(MouseEvent event) {
         }
     }
 
-    private void gitPatReveal(MouseEvent event) {
-        gitPatText = gitPat.getText();
-        gitPatCaretPosition = gitPat.getCaretPosition();
-        gitPat.clear();
-        gitPat.setPromptText(gitPatText);
-    }
-
-    private void gitPatMask(MouseEvent event) {
-        if (!"".equals(gitPatText)) {
-            gitPat.setText(gitPatText);
-            gitPat.positionCaret(gitPatCaretPosition);
-            gitPat.setPromptText("");
-            gitPatText = "";
-            gitPatCaretPosition = 0;
-        }
-    }
-
     @FXML
     void checkConnection() {
         viewModel.checkConnection();