test: make Bats tests self-contained (no external helpers)

Author: Kikolator

test/completion.bats

@@ -7,12 +7,12 @@
   run zsh -c '
     export DEV_ROOT="'"$fake_root"'"
     source "$BATS_TEST_DIRNAME/../proj-jumper.plugin.zsh"
-    reply=()               # zsh completions are returned in $reply
-    _proj_complete ""      # call the completion function
+    reply=()
+    _proj_complete ""      # populate $reply
     print -l "${reply[@]}"
   '
 
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"alpha"* ]]
-  [[ "$output" == *"beta"* ]]
+  [ \"$status\" -eq 0 ]
+  [[ \"$output\" == *alpha* ]]
+  [[ \"$output\" == *beta* ]]
 }

test/proj_config_sets_root.bats

@@ -2,7 +2,7 @@
 
 @test "proj-config appends PROJ_DEV_ROOT export to .zshrc" {
   temp_home="$(mktemp -d)"
-  export ZDOTDIR="$temp_home"     # make plugin look here for .zshrc
+  export ZDOTDIR="$temp_home"
   touch "$ZDOTDIR/.zshrc"
 
   new_root="$(mktemp -d)"
@@ -12,9 +12,6 @@
     proj-config "'"$new_root"'"
   '
 
-  # command succeeds
-  [ "$status" -eq 0 ]
-
-  # line actually added
-  grep -q "export PROJ_DEV_ROOT=$new_root" "$ZDOTDIR/.zshrc"
+  [ \"$status\" -eq 0 ]
+  grep -q \"export PROJ_DEV_ROOT=$new_root\" \"\$ZDOTDIR/.zshrc\"
 }

test/proj_help.bats

@@ -1,11 +1,10 @@
 #!/usr/bin/env bats
 
-setup() {
-  load '../test_helpers/load_plugin'   # tiny helper that sources the plugin
-}
-
 @test "proj --help prints usage" {
-  run proj --help
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"Usage:"* ]]
+  run zsh -c "
+    source \"\$BATS_TEST_DIRNAME/../proj-jumper.plugin.zsh\"
+    proj --help
+  "
+  [ \"$status\" -eq 0 ]
+  [[ \"$output\" == *'Usage:'* ]]
 }

test/proj_root_missing.bats

@@ -1,18 +1,15 @@
 #!/usr/bin/env bats
 
-load 'test_helper/bats-support/load'  # optional if bats-support is available
-load 'test_helper/bats-assert/load'   # optional if bats-assert is available
-
 @test "proj warns and exits 1 when DEV_ROOT is missing" {
   missing_root="$(mktemp -d)"
-  rmdir "$missing_root"        # ensure the directory truly does not exist
+  rmdir "$missing_root"
 
   run zsh -c "
     export DEV_ROOT='$missing_root'
     source \"\$BATS_TEST_DIRNAME/../proj-jumper.plugin.zsh\"
     proj
   "
 
-  [ "$status" -eq 1 ]
-  [[ "$output" == ⚠️* ]] || [[ "$output" == *'not found'* ]]
+  [ \"\$status\" -eq 1 ]
+  [[ \"\$output\" == ⚠️* ]] || [[ \"\$output\" == *'not found'* ]]
 }

test/proj_unknown_project.bats

@@ -1,18 +1,15 @@
 #!/usr/bin/env bats
 
-load 'test_helper/bats-support/load'  # optional
-load 'test_helper/bats-assert/load'   # optional
-
 @test "proj exits 1 and warns when project does not exist" {
   fake_root="$(mktemp -d)"
-  mkdir "$fake_root/alpha"       # a real directory to prove root exists
+  mkdir "$fake_root/alpha"
 
   run zsh -c "
     export DEV_ROOT='$fake_root'
-    source \"$BATS_TEST_DIRNAME/../proj-jumper.plugin.zsh\"
+    source \"\$BATS_TEST_DIRNAME/../proj-jumper.plugin.zsh\"
     proj doesnotexist
   "
 
-  [ "$status" -eq 1 ]
-  [[ "$output" == *'No such project'* ]]
+  [ \"\$status\" -eq 1 ]
+  [[ \"\$output\" == *'No such project'* ]]
 }