Skip to content

feat: Active item portal to render item over all other content #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 18, 2025

Conversation

MatiPl01
Copy link
Owner

@MatiPl01 MatiPl01 commented Mar 10, 2025

Description

This PR adds active item portal that teleports the currently dragged item above other components. It can be used to display active item above navigator or outside of the scrollable component bounds (like a ScrollView that clamps the content inside it).

Important

The current implementation doesn't work in the expo example because it is not compatible with reanimated 3.17.x, where this issue with onLayout callback not being called was resolved.

Example recordings

Without PortalProvider With PortalProvider
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-17.at.17.02.15.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-17.at.17.01.39.mp4

@MatiPl01 MatiPl01 self-assigned this Mar 10, 2025
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
react-native-sortables-docs ⬜️ Ignored (Inspect) Visit Preview Mar 17, 2025 5:12pm

@MatiPl01 MatiPl01 force-pushed the feat/active-item-portal branch from 0540905 to bdc9288 Compare March 14, 2025 11:46
@MatiPl01 MatiPl01 marked this pull request as ready for review March 17, 2025 17:12
@MatiPl01 MatiPl01 merged commit ecfe289 into main Mar 18, 2025
6 checks passed
@MatiPl01 MatiPl01 deleted the feat/active-item-portal branch March 18, 2025 09:33
MatiPl01 pushed a commit that referenced this pull request Mar 23, 2025
# [1.4.0](v1.3.2...v1.4.0) (2025-03-23)

### Bug Fixes

* Active item portal provider on web ([#312](#312)) ([d9660d2](d9660d2))
* Default keyExtractor behavior for numeric values ([#301](#301)) ([d7cf171](d7cf171))
* Flex ordering after recent changes ([#313](#313)) ([9df1fa5](9df1fa5)), closes [#310](#310)
* onPress not working after disabling drag ([#307](#307)) ([d1cbdc9](d1cbdc9)), closes [#306](#306)

### Features

* Active item portal to render item over all other content ([#299](#299)) ([ecfe289](ecfe289))
* Fixed items support for Sortable.Grid ([#310](#310)) ([d0cb59e](d0cb59e)), closes [#305](#305) [#999](https://github.com/MatiPl01/react-native-sortables/issues/999)
@MatiPl01
Copy link
Owner Author

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant