fix(Twitch): Fix Twitch embed#131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 215 220 +5
Branches 27 28 +1
=========================================
+ Hits 215 220 +5
Continue to review full report at Codecov.
|
3e2baf5 to
fe67ccf
Compare
FabioRosado
left a comment
There was a problem hiding this comment.
I know I am not a maintainer but the chances look good to me to be honest. It might be worth mentioning that you can use localhost on a non-https site (but again I didn't have much luck with it), but it does make a lot of sense to mention it on the docs.
Also I would like to mention that I like the option for the config, it could also bring some help to other transformers in the future 🤔
fe67ccf to
863a6e5
Compare
BREAKING CHANGE: You'll now need to pass a required `parent` option whenever you're using the Twitch service BREAKING CHANGE: Twitch embeds can only be embedded on HTTPS websites. Check out the Gatsby docs for setting this up when developing locally.
863a6e5 to
4879048
Compare
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
As announced on their forum, Twitch updated the way the embedded video player is initiated.
This means we now have to pass a
parent, which is a list of the domains your content appears on.BREAKING CHANGE: You'll now need to pass a required
parentoption whenever you're using the Twitch serviceBREAKING CHANGE: Twitch embeds can only be embedded on HTTPS websites. Check out the Gatsby
docs for setting this up when developing locally.
Fixes #128