Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Feature: Load and apply a custom coverprofile#2361

Merged
ramya-rao-a merged 12 commits intomicrosoft:masterfrom
Eun:load-coverprofile-from-path
Jan 26, 2020
Merged

Feature: Load and apply a custom coverprofile#2361
ramya-rao-a merged 12 commits intomicrosoft:masterfrom
Eun:load-coverprofile-from-path

Conversation

@Eun
Copy link
Copy Markdown
Contributor

@Eun Eun commented Mar 1, 2019

This feature allows the user to load and apply a custom coverprofile from the filesystem.

Related to:
#816
#1596

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 1, 2019

CLA assistant check
All CLA requirements met.

Comment thread src/goMain.ts Outdated
Copy link
Copy Markdown
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is your first PR contribution to this project @Eun
Thanks & Welcome!

While this PR definitely helps with #1596, it doesn't help with #816 as the applyCodeCoverageToAllEditors() method only works with single packages.

Regardless, this is definitely useful to load cover profile.

There is a tiny suggested change I have made in a comment after which we can merge this PR.

@ramya-rao-a
Copy link
Copy Markdown
Contributor

Pushed a few commits to

  • merge code from master branch & resolve conflicts
  • fix linting errors
  • throw error if provided path doesn't exist

@ramya-rao-a ramya-rao-a merged commit 634da08 into microsoft:master Jan 26, 2020
@Eun Eun deleted the load-coverprofile-from-path branch January 26, 2020 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants