Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Update .travis.yml#2915

Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom
ryboe:master
Dec 3, 2019
Merged

Update .travis.yml#2915
ramya-rao-a merged 1 commit intomicrosoft:masterfrom
ryboe:master

Conversation

@ryboe
Copy link
Copy Markdown
Contributor

@ryboe ryboe commented Nov 24, 2019

changes

  • Use the latest Ubuntu VM available (18.04)
  • Only clone the most recent commit. Saves a few seconds
  • Remove references to Go 1.8
  • Sort long list of go get commands

@msftclas
Copy link
Copy Markdown

msftclas commented Nov 24, 2019

CLA assistant check
All CLA requirements met.

Comment thread .travis.yml
- tip

git:
depth: 1
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only clone the most recent commit. This saves a few seconds of CI time.

Comment thread .travis.yml
before_install:
# Call xvfb directly on linux runs and give it time to start
- if [ $TRAVIS_OS_NAME == "linux" ]; then
- if [[ $TRAVIS_OS_NAME == "linux" ]]; then
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[ is a bash best practice.

Comment thread .travis.yml
- go get -u -v github.com/uudashr/gopkgs/cmd/gopkgs
- go get -u -v github.com/zmb3/gogetdoc
- go get -u -v golang.org/x/lint/golint
- go get -u -v golang.org/x/tools/cmd/gorename
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the checks for Go 1.8, which we're not testing anymore. I also sorted this list.

Use the latest Ubuntu VM available (18.04).
Only clone the most recent commit. Speeds up cloning.
Remove references to Go 1.8.
Sort long list of `go get` commands.
Comment thread .travis.yml
@@ -1,25 +1,28 @@
language: go

dist: bionic
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run on an Ubuntu 18.04 VM. This is the latest Ubuntu currently offered by Travis.

Comment thread .travis.yml
allow_failures:
- go: tip

sudo: false
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used to be the way to specify that you want to run in a container, but this has been deprecated.

Copy link
Copy Markdown
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @y0ssar1an, these are some good catches!

It looks like this is your first PR contribution to this project, Thanks & Welcome!

@ramya-rao-a ramya-rao-a merged commit 4060ab1 into microsoft:master Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants