This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Update .travis.yml#2915
Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom Dec 3, 2019
ryboe:master
Merged
Conversation
ryboe
commented
Nov 24, 2019
| - tip | ||
|
|
||
| git: | ||
| depth: 1 |
Contributor
Author
There was a problem hiding this comment.
Only clone the most recent commit. This saves a few seconds of CI time.
| before_install: | ||
| # Call xvfb directly on linux runs and give it time to start | ||
| - if [ $TRAVIS_OS_NAME == "linux" ]; then | ||
| - if [[ $TRAVIS_OS_NAME == "linux" ]]; then |
Contributor
Author
There was a problem hiding this comment.
[[ is a bash best practice.
| - go get -u -v github.com/uudashr/gopkgs/cmd/gopkgs | ||
| - go get -u -v github.com/zmb3/gogetdoc | ||
| - go get -u -v golang.org/x/lint/golint | ||
| - go get -u -v golang.org/x/tools/cmd/gorename |
Contributor
Author
There was a problem hiding this comment.
I removed the checks for Go 1.8, which we're not testing anymore. I also sorted this list.
Use the latest Ubuntu VM available (18.04). Only clone the most recent commit. Speeds up cloning. Remove references to Go 1.8. Sort long list of `go get` commands.
ryboe
commented
Nov 24, 2019
| @@ -1,25 +1,28 @@ | |||
| language: go | |||
|
|
|||
| dist: bionic | |||
Contributor
Author
There was a problem hiding this comment.
Run on an Ubuntu 18.04 VM. This is the latest Ubuntu currently offered by Travis.
| allow_failures: | ||
| - go: tip | ||
|
|
||
| sudo: false |
Contributor
Author
There was a problem hiding this comment.
This used to be the way to specify that you want to run in a container, but this has been deprecated.
ramya-rao-a
approved these changes
Dec 3, 2019
Contributor
ramya-rao-a
left a comment
There was a problem hiding this comment.
Thanks @y0ssar1an, these are some good catches!
It looks like this is your first PR contribution to this project, Thanks & Welcome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
go getcommands