This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Show warning if 'program' attribute is used in 'remote'#2999
Merged
ramya-rao-a merged 3 commits intomicrosoft:masterfrom Mar 24, 2020
quoctruong:quoct/show_warning
Merged
Show warning if 'program' attribute is used in 'remote'#2999ramya-rao-a merged 3 commits intomicrosoft:masterfrom quoctruong:quoct/show_warning
ramya-rao-a merged 3 commits intomicrosoft:masterfrom
quoctruong:quoct/show_warning
Conversation
ramya-rao-a
reviewed
Mar 19, 2020
Contributor
ramya-rao-a
left a comment
ramya-rao-a
left a comment
There was a problem hiding this comment.
Any idea why the whole file is appearing in the diff?
ramya-rao-a
reviewed
Mar 20, 2020
| * Show warningMessage to the user if warningCondition is met. | ||
| * If the user chooses not to see the warning again, sets it to the global state. | ||
| */ | ||
| private showWarning(warningKey: string, warningMessage: string, warningCondition: boolean) { |
Contributor
There was a problem hiding this comment.
If warningCondition is true, then the entire code path in this method is a no-op. It would be easier to read the code if this condition was checked outside and this function called only if it were true
Contributor
There was a problem hiding this comment.
Also would suggest renaming warningKey to ignoreWarningKey
quoctruong
commented
Mar 23, 2020
Contributor
Author
quoctruong
left a comment
quoctruong
left a comment
There was a problem hiding this comment.
@ramya-rao-a PTAL
ramya-rao-a
reviewed
Mar 23, 2020
| `Request type of 'launch' with mode 'remote' is deprecated, please use request type 'attach' with mode 'remote' instead.`); | ||
| } | ||
|
|
||
| if (debugConfiguration.request === 'launch' && debugConfiguration['mode'] === 'remote') { |
Contributor
There was a problem hiding this comment.
Shouldn't the request here be attach?
Contributor
Author
|
@ramya-rao-a PTAL |
ramya-rao-a
approved these changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the debugger in remote attach mode, users have to use
cwdinstead ofprogram. This can be confusing so we should show a warning message.