This repository was archived by the owner on Jul 15, 2023. It is now read-only.
src/goLanguageServer: fix missing gopls detection logic#3197
Merged
ramya-rao-a merged 2 commits intomicrosoft:masterfrom Apr 25, 2020
Merged
src/goLanguageServer: fix missing gopls detection logic#3197ramya-rao-a merged 2 commits intomicrosoft:masterfrom
ramya-rao-a merged 2 commits intomicrosoft:masterfrom
Conversation
Also, update getMissingTools to check the tool's existence by simply checking whether the resolved tool path is absolute. getBinPath already ran the existence check before returning the absolute path for the tool. Fixes microsoft#3194
stamblerre
reviewed
Apr 20, 2020
Contributor
|
Thanks for doing this! |
ramya-rao-a
approved these changes
Apr 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, update getMissingTools to check the tool's existence
by simply checking whether the resolved tool path is absolute.
getBinPath already ran the existence check before returning
the absolute path for the tool.
Fixes #3194