This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Use -imports-only option from go-outline#550
Merged
ramya-rao-a merged 2 commits intomicrosoft:masterfrom Oct 26, 2016
Merged
Conversation
ramya-rao-a
force-pushed
the
gooutline-updates
branch
3 times, most recently
from
3ac4060 to
9ea6a2b
Compare
ramya-rao-a
force-pushed
the
gooutline-updates
branch
from
9ea6a2b to
9d2a46e
Compare
roblourens
approved these changes
Oct 25, 2016
| export function documentSymbols(options: GoOutlineOptions): Promise<GoOutlineDeclaration[]> { | ||
| return new Promise<GoOutlineDeclaration[]>((resolve, reject) => { | ||
| let gooutline = getBinPath('go-outline'); | ||
| let gooutlineFlags = ['-f', options.fileName]; |
| ); | ||
| return Promise.all(promises); | ||
| }).then(() => { | ||
| vscode.commands.executeCommand('workbench.action.closeActiveEditor'); |
Member
There was a problem hiding this comment.
executeCommand returns a promise - don't know if it matters though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
go-outlinetool to get list of imported packages in the current file.go-outlineinternally parses the file to return all symbols. But since we need only imports, the whole file need not be parsed. lukehoban/go-outline#4 added the option to parse only the initial part of the file that contains the imports.This PR uses this option.