This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Remove pkgs from completion if identifier with same name exists#608
Merged
ramya-rao-a merged 2 commits intomicrosoft:masterfrom Nov 9, 2016
Merged
Remove pkgs from completion if identifier with same name exists#608ramya-rao-a merged 2 commits intomicrosoft:masterfrom
ramya-rao-a merged 2 commits intomicrosoft:masterfrom
Conversation
roblourens
approved these changes
Nov 9, 2016
ramya-rao-a
force-pushed
the
same-name-as-pkg
branch
from
79ee87b to
482b219
Compare
ramya-rao-a
force-pushed
the
same-name-as-pkg
branch
from
482b219 to
b90a718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #598
Say there is a variable by the name
mathin a Go file. Completion items after typingmawill include results for both the variablemathand the packagemaththat can be imported. The latter is not valid.This PR excludes importable packages with same name as any other identifier in the Go file