Outdent issue with Typescript

[normalser]

• VSCode Version: 1.4.0-insider and 1.3.1
• OS Version: OSX

Steps to Reproduce:

1 - Highlight

2 - Outdent with Cmd + [

Result (first issue):

3 - Outdent again with Cmd + [

Result (second issue):

Expected behavior:

First outdent:

Second outdent:

[weinand]

@wallverb I can not reproduce this problem.
It is possible that this issue is caused by an installed extension. Can you try to run VS Code without extensions? From the command line, execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

[normalser]

@weinand here are the steps to recreate:

1. mkdir test
2. code --disable-extensions test
3. Create file test.ts
4. Paste this into test.ts

const data = {
  "typeName": "chart",
      "data": {
        "header": "my title"
      }
}



export class Sidebar {
    renderLink() {
        return {
            test: true
        }
    }
}

5 - Try to outdent:

If works then proceed to step 6

6 - Close VSCode
7 - code --disable-extensions test
8 - Try to outdent again

I'm getting the issue from above screenshots

[weinand]

@wallverb I can reproduce with your snippet. This issue is independent from TypeScript.

The snippet has inconsistent indentation: 6 lines seem to use 4 spaces for one indentation level, 3 lines use 2 spaces. Since you are probably using the default editor setting "editor.detectIndentation": true, VS Code determines the tab size to be 4 (you can see this in the editor's status bar at the bottom).

Since the outdent operation has to move the lines to valid tab positions, the result is unexpected but correct.

Your expected behaviour would require a tabSize of 2. To achieve this, you will have to use these settings:

"editor.tabSize": 2,
"editor.detectIndentation": false

[normalser]

Right, I knew it was related to mix of 2 spaces and 4 spaces tabs - but even that assuming that VSCode detected Spaces: 4 it shouldn't "break" children

In other words: (assuming Spaces: 4)

Starting state:

Current outdent operation results in:

(notice how children got unaligned)

Ideal situation would be if VSCode could "fix" the indentation difference and for example create this output:

("data" was only moved by 2 spaces left to fit into 4 spaces tab and children got "fixed")

or at least just move everything by 2 spaces to the left (so `"data" follows the 4 spaces tab) or (what Atom does) - just move everything 4 spaces to the left - without "breaking children"

[alexdima]

This issue touches on two topics:

• should outdent "dumbly" remove x spaces from each line -- today it tries to snap code into tab stops.
• should outdent be a no-op if not all lines have leading whitespace.

I think both behaviours have pros and cons. i.e. I have a feeling they should be expressed as settings.

[lewisl9029]

IMO dumb indentation should be the default, since that's the default behavior for most editors, and is least likely to break existing formatting. Especially in languages like Clojure where partial indents are very prevalent (see #15598).

That's my 2c, but as long as it's configurable at all as a setting, I can live with it.

[BillDenton]

Similar problem in C++ (also C). For example,

Do outdent:

Second parameter was aligned, now isn't. A dumb indentation should be default. This would make it work as I expect, i.e. not change the layout. When one of the lines doesn't contain whitespace either stop working or start stripping whitespace (in tab size steps) from the other lines. This is behaviour in SlickEdit, which I find useful occasionally.