Skip to content

Commit 108208b

Browse files
googs1025ModiCodeCraftsman
authored andcommitted
[Misc]: ensure cache sync before starting controller reconcile (vllm-project#1219)
Ensure cache sync before starting controller reconcile Signed-off-by: googs1025 <[email protected]> Signed-off-by: Modi Tamam <[email protected]>
1 parent 7c2c5f9 commit 108208b

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

pkg/controller/modeladapter/modeladapter_controller.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,12 @@ func newReconciler(mgr manager.Manager, runtimeConfig config.RuntimeConfig) (rec
146146
return nil, err
147147
}
148148

149+
klog.Info("Waiting for caches to sync")
150+
if ok := cacher.WaitForCacheSync(context.TODO()); !ok {
151+
return nil, errors.New("modeladapter controller: failed to sync cache")
152+
}
153+
klog.Info("All caches synced")
154+
149155
// Let's generate the clientset and use ModelAdapterLister here as well.
150156
podLister := corelisters.NewPodLister(podInformer.(toolscache.SharedIndexInformer).GetIndexer())
151157
serviceLister := corelisters.NewServiceLister(serviceInformer.(toolscache.SharedIndexInformer).GetIndexer())

pkg/controller/modelrouter/modelrouter_controller.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package modelrouter
1818

1919
import (
2020
"context"
21+
"errors"
2122
"fmt"
2223
"strconv"
2324

@@ -105,6 +106,12 @@ func Add(mgr manager.Manager, runtimeConfig config.RuntimeConfig) error {
105106
DeleteFunc: modelRouter.deleteRouteFromRayClusterFleet,
106107
})
107108

109+
klog.Info("Waiting for caches to sync")
110+
if ok := cacher.WaitForCacheSync(context.TODO()); !ok {
111+
return errors.New("modelrouter controller: failed to sync cache")
112+
}
113+
klog.Info("All caches synced")
114+
108115
return err
109116
}
110117

0 commit comments

Comments
 (0)