Skip to content

Commit 4894afb

Browse files
author
YossiGreen
committed
- removed unnecessary code.
1 parent 8eabf10 commit 4894afb

20 files changed

+376
-400
lines changed

src/actions/ExposuresActions.ts

Lines changed: 36 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -19,44 +19,40 @@ interface dismissedExposures {
1919
}
2020

2121

22-
2322
export const setExposures = (exposures: Exposure[]) => async (dispatch: any) => {
2423
const dismissedExposures = await AsyncStorage.getItem(DISMISSED_EXPOSURES);
2524

2625
let filteredExposures;
27-
let pastExposures: Exposure[] = exposures
26+
let pastExposures: Exposure[] = exposures;
2827

2928
if (dismissedExposures) {
3029
const parsedDismissedExposures: number[] | dismissedExposures[] = JSON.parse(dismissedExposures);
3130
filteredExposures = exposures.filter((exposure: Exposure) => parsedDismissedExposures.some((item: number | dismissedExposures) => {
32-
if (typeof item === 'number') {
33-
return item !== exposure.properties.OBJECTID
34-
} else {
35-
return item.OBJECTID !== exposure.properties.OBJECTID
36-
}
37-
})
38-
)
31+
if (typeof item === 'number') {
32+
return item !== exposure.properties.OBJECTID;
33+
}
34+
return item.OBJECTID !== exposure.properties.OBJECTID;
35+
}));
3936
pastExposures = exposures.map((expo) => {
4037
if (parsedDismissedExposures.some((item: number | dismissedExposures) => {
4138
if (typeof item === 'number') {
42-
return item === expo.properties.OBJECTID
43-
} else {
44-
return item.OBJECTID === expo.properties.OBJECTID
39+
return item === expo.properties.OBJECTID;
4540
}
41+
return item.OBJECTID === expo.properties.OBJECTID;
4642
})) {
4743
if (typeof parsedDismissedExposures === 'number') {
48-
expo.properties.wasThere = parsedDismissedExposures ? true : false
44+
expo.properties.wasThere = !!parsedDismissedExposures;
4945
} else {
50-
const {wasThere} = parsedDismissedExposures.find(({OBJECTID}) => expo.properties.OBJECTID === OBJECTID )
51-
expo.properties.wasThere = wasThere ?? false
46+
const { wasThere } = parsedDismissedExposures.find(({ OBJECTID }) => expo.properties.OBJECTID === OBJECTID);
47+
expo.properties.wasThere = wasThere ?? false;
5248
}
5349
}
54-
return expo
55-
})
50+
return expo;
51+
});
5652
}
5753

58-
console.log("length", filteredExposures?.length, pastExposures.length);
59-
54+
console.log('length', filteredExposures?.length, pastExposures.length);
55+
6056
dispatch({ type: UPDATE_EXPOSURES, payload: { exposures: filteredExposures || exposures } });
6157
dispatch({ type: UPDATE_PAST_EXPOSURES, payload: { pastExposures } });
6258

@@ -65,17 +61,17 @@ export const setExposures = (exposures: Exposure[]) => async (dispatch: any) =>
6561
// check if first item in array is number
6662
if (typeof parsedDismissedExposures[0] === 'number') {
6763
const convertExposureToString: string = JSON.stringify(parsedDismissedExposures.map((OBJECTID: number) => {
68-
if (typeof OBJECTID !== 'number') return OBJECTID
64+
if (typeof OBJECTID !== 'number') return OBJECTID;
6965
return ({
7066
OBJECTID,
7167
wasThere: false
72-
})
73-
}))
68+
});
69+
}));
7470

75-
await AsyncStorage.setItem(DISMISSED_EXPOSURES, convertExposureToString)
71+
await AsyncStorage.setItem(DISMISSED_EXPOSURES, convertExposureToString);
7672
}
7773
}
78-
}
74+
};
7975

8076
export const setValidExposure = (exposure: Exposure) => async (dispatch: any) => {
8177
try {
@@ -109,44 +105,40 @@ export const dismissExposure = (exposureId: number) => async (dispatch: any) =>
109105
};
110106

111107
export const setExposureSelected = ({ index, wasThere }) => async (dispatch: any, getState: any) => {
108+
const exposures = [...getState().exposures.exposures];
109+
exposures[index].properties.wasThere = wasThere;
112110

113-
const exposures = [...getState().exposures.exposures]
114-
exposures[index].properties.wasThere = wasThere
115-
116-
dispatch({ type: REPLACE_EXPOSURES, payload: { exposures } })
111+
dispatch({ type: REPLACE_EXPOSURES, payload: { exposures } });
117112
const dismissedExposures = await AsyncStorage.getItem(DISMISSED_EXPOSURES);
118113
if (dismissedExposures) {
119114
const parsedDismissedExposures: number[] | dismissedExposures[] = JSON.parse(dismissedExposures);
120115
// avoid duplicates
121116
const idx: number = parsedDismissedExposures.findIndex((item: number | dismissedExposures) => {
122-
if(typeof item ==='number'){
123-
return exposures[index].properties.OBJECTID === item
124-
} else {
125-
return exposures[index].properties.OBJECTID === item.OBJECTID
126-
}
127-
})
128-
if(idx > -1) {
129-
if(typeof parsedDismissedExposures[idx] === 'number') {
130-
parsedDismissedExposures[idx] = { OBJECTID: exposures[index].properties.OBJECTID, wasThere }
117+
if (typeof item === 'number') {
118+
return exposures[index].properties.OBJECTID === item;
119+
}
120+
return exposures[index].properties.OBJECTID === item.OBJECTID;
121+
});
122+
if (idx > -1) {
123+
if (typeof parsedDismissedExposures[idx] === 'number') {
124+
parsedDismissedExposures[idx] = { OBJECTID: exposures[index].properties.OBJECTID, wasThere };
131125
} else {
132-
133-
parsedDismissedExposures[idx].wasThere = wasThere
126+
parsedDismissedExposures[idx].wasThere = wasThere;
134127
}
135128
} else {
136-
parsedDismissedExposures.push({ OBJECTID: exposures[index].properties.OBJECTID, wasThere })
129+
parsedDismissedExposures.push({ OBJECTID: exposures[index].properties.OBJECTID, wasThere });
137130
}
138131
await AsyncStorage.setItem(DISMISSED_EXPOSURES, JSON.stringify(parsedDismissedExposures));
139132
} else {
140133
await AsyncStorage.setItem(DISMISSED_EXPOSURES, JSON.stringify([{ OBJECTID: exposures[index].properties.OBJECTID, wasThere }]));
141134
}
142-
}
135+
};
143136

144137
export const replacePastExposureSelected = (payload: Exposure[]) => async (dispatch: any) => {
145-
146-
dispatch({ type: REPLACE_PAST_EXPOSURES, payload })
138+
dispatch({ type: REPLACE_PAST_EXPOSURES, payload });
147139

148140
await AsyncStorage.setItem(DISMISSED_EXPOSURES, JSON.stringify(payload.map((exposure: Exposure) => ({
149141
OBJECTID: exposure.properties.OBJECTID,
150142
wasThere: exposure.properties.wasThere
151143
}))));
152-
}
144+
};

src/components/Drawer/Home.tsx

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,38 +8,38 @@ import DrawerContent from './DrawerContent';
88
import ExposuresHistory from '../Main/ExposuresHistory/ExposuresHistory';
99
import ExposuresHistoryEdit from '../Main/ExposuresHistory/ExposuresHistoryEdit';
1010
import ExposureHistoryRelief from '../Main/ExposuresHistory/ExposureHistoryRelief';
11-
import ExposureDetected from '../Main/ExposuresDetected'
12-
import ExposureInstructions from '../Main/ExposureInstructions'
13-
import ExposureRelief from '../Main/ExposureRelief'
11+
import ExposureDetected from '../Main/ExposuresDetected';
12+
import ExposureInstructions from '../Main/ExposureInstructions';
13+
import ExposureRelief from '../Main/ExposureRelief';
1414
import ChangeLanguageScreen from '../ChangeLanguage/ChangeLanguageScreen';
1515
import LocationHistory from '../Main/LocationHistory/LocationHistory';
1616
import FilterDriving from '../Main/FilterDriving/FilterDriving';
1717
import ShareLocations from '../ShareLocations/ShareLocations';
18-
import { LocaleReducer,ExposuresReducer, Store, Exposure } from '../../types';
18+
import { LocaleReducer, ExposuresReducer, Store, Exposure } from '../../types';
1919
import MapModal from '../Main/MapModal';
2020

2121

2222
const Stack = createStackNavigator();
2323

24-
const DEFAULT_SCREEN = "ScanHome"
24+
const DEFAULT_SCREEN = 'ScanHome';
2525

26-
const DrawerStack = ({navigation}) => {
27-
const { exposures } = useSelector<Store, ExposuresReducer>(state => state.exposures)
28-
const [initialRouteName, setInitialRouteName] = useState('')
26+
const DrawerStack = ({ navigation }) => {
27+
const { exposures } = useSelector<Store, ExposuresReducer>(state => state.exposures);
28+
const [initialRouteName, setInitialRouteName] = useState('');
2929

3030
useEffect(() => {
3131
AsyncStorage.getItem('INIT_ROUTE_NAME')
3232
.then(initRouteString => setInitialRouteName(initRouteString ?? DEFAULT_SCREEN))
33-
.catch(() => setInitialRouteName(DEFAULT_SCREEN))
34-
},[])
33+
.catch(() => setInitialRouteName(DEFAULT_SCREEN));
34+
}, []);
3535

3636
useEffect(() => {
37-
if(exposures.some((exposure: Exposure) => exposure.properties.wasThere === undefined && initialRouteName !== '')){
38-
navigation.navigate('ExposureDetected')
37+
if (exposures.some((exposure: Exposure) => exposure.properties.wasThere === undefined && initialRouteName !== '')) {
38+
navigation.navigate('ExposureDetected');
3939
}
40-
}, [exposures, initialRouteName])
41-
42-
if(!initialRouteName) return null
40+
}, [exposures, initialRouteName]);
41+
42+
if (!initialRouteName) return null;
4343

4444
return (
4545
<Stack.Navigator mode="modal" headerMode="none" initialRouteName={initialRouteName}>
@@ -62,7 +62,7 @@ const Drawer = createDrawerNavigator();
6262

6363
const Home = () => {
6464
const { isRTL } = useSelector<Store, LocaleReducer>(state => state.locale);
65-
65+
6666
return (
6767
<>
6868
<Drawer.Navigator

src/components/Loading.tsx

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React, { useEffect, useRef, useState, FunctionComponent } from 'react';
22
import { View, StyleSheet } from 'react-native';
33
import { connect } from 'react-redux';
4-
import { bindActionCreators } from 'redux';
54
import { CardStyleInterpolators, createStackNavigator } from '@react-navigation/stack';
65
import AsyncStorage from '@react-native-community/async-storage';
76
import moment from 'moment';
@@ -20,7 +19,7 @@ import { purgeSamplesDB, startSampling } from '../services/SampleService';
2019
import { updateLocationsTimesToUTC } from '../services/LocationService';
2120
import { startForegroundTimer } from '../services/Tracker';
2221
import { clusterLocationsOnAppUpdate } from '../services/ClusteringService';
23-
import { addDataToBLEDB, initBLETracing, registerBLEListeners } from '../services/BLEService';
22+
import { initBLETracing, registerBLEListeners } from '../services/BLEService';
2423
import { IntersectionSickDatabase } from '../database/Database';
2524
import { initConfig } from '../config/config';
2625
import store from '../store';
@@ -82,19 +81,15 @@ const Loading : FunctionComponent<Props> = (
8281
showForceTerms,
8382
checkForceUpdate,
8483
termsVersion
85-
}
84+
}
8685
) => {
8786
const shouldShowForceTerms = useRef(false);
8887

8988
const [initialRoute, setInitialRoute] = useState('');
9089

9190
useEffect(() => {
92-
// TODO remove once functionality implemented
93-
addDataToBLEDB();
94-
9591
registerBLEListeners();
9692
appLoadingActions();
97-
9893
}, []);
9994

10095
useEffect(() => {
@@ -172,9 +167,9 @@ const Loading : FunctionComponent<Props> = (
172167
}
173168

174169
const dbSick = new IntersectionSickDatabase();
175-
await dbSick.purgeIntersectionSickTable(moment().subtract(2, 'week').unix() * 1000)
170+
await dbSick.purgeIntersectionSickTable(moment().subtract(2, 'week').unix() * 1000);
176171
const exposures = await dbSick.listAllRecords();
177-
172+
178173
await store().dispatch(setExposures(exposures.map((exposure: any) => ({ properties: { ...exposure } }))));
179174

180175
const firstPointTS = JSON.parse(await AsyncStorage.getItem(FIRST_POINT_TS) || 'false');

0 commit comments

Comments
 (0)