fix: turn off logging stderr+out to file (#454)

* fix: turn off logging stderr+out to file

Removing the log file so we can just log to the container
stdout and stderr to be picked up by Loki or other means.

* fix: fixed depends_on to the actual loki service name

* chore: updated README.md about logs

Specifically we changed the container entry.sh script to not
redirect the logs to files.  This enables log scraping directly
from the containers into log collection services like Loki.

Author: allan-bailey

narwhal/Docker/README.md

@@ -36,23 +36,14 @@ since the narwhal node binary needs to be built from the source code.) And then
 a cluster for *four nodes* by doing the necessary setup for `primary` and `worker` nodes. Each
 `primary` node will be connected to *one worker* node.
 
-The logs for each validator (primary & worker nodes) can be found in the `logs` folder under the corresponding
-validator folder.
-
-> **Note**: You will find across the codebase the name *Authority* when we describe
-> the entity participating in the Narwhal protocol that verifies and signs the produced headers. An 
-> authority is composed of a `primary` node and one or more `worker` nodes. Since Authority is not a widely
-> used term, we are referring instead to our *primary + worker* node pairs as **Validator**.
-
-The `logs` folder is created once the node is bootstrapped via `docker-compose`. 
-For example, for the primary node of the validator-0, the logs will be found in
-the folder `validators/validator-0/logs` with the name `log-primary.txt`. To monitor
-the logging of a node in real time, simply `tail` the log:
+The logs from the `primary` and `worker` nodes are available via
 ```
-$ tail -f validators/validator-0/logs/log-primary.txt
+docker-compose logs primary_<num>
+
+docker-compose logs worker_<num>
 ```
 
-By default, the production (release) version of the Narwhal node will be compiled when the Docker image is being built.
+	By default, the production (release) version of the Narwhal node will be compiled when the Docker image is being built.
 To build the Docker image with the development version of Narwhal, which will lead to smaller compile times and
 smaller binary (and image) size, you run the `docker-compose` command as:
 ```
@@ -223,6 +214,10 @@ Loki is a log collector and processor.  It is exposed as a datasource
 in Grafana and makes the logs easily searchable.
 	- https://grafana.com/oss/loki/
 
+Currently there are no Loki dashboards defined, however you can
+browse the logs via the "Explorer", selecting the Loki datasource.
+
+
 ## Troubleshooting
 
 #### 1. Compile errors when building Docker image

narwhal/Docker/entry.sh

@@ -15,11 +15,9 @@ else
   if [[ "$NODE_TYPE" = "primary" ]]; then
     # Clean up only the primary node's data
     rm -r "/validators/validator-$VALIDATOR_ID/db-primary"
-    rm -r "/validators/validator-$VALIDATOR_ID/logs/log-primary.txt"
   elif [[ "$NODE_TYPE" = "worker" ]]; then
     # Clean up only the specific worker's node data
     rm -r "/validators/validator-$VALIDATOR_ID/db-worker-${WORKER_ID}"
-    rm -r "/validators/validator-$VALIDATOR_ID/logs/log-worker-${WORKER_ID}.txt"
   fi
 fi
 
@@ -32,7 +30,7 @@ if [[ "$NODE_TYPE" = "primary" ]]; then
   --committee $COMMITTEE_PATH \
   --store "/validators/validator-$VALIDATOR_ID/db-primary" \
   --parameters $PARAMETERS_PATH \
-  primary $CONSENSUS_DISABLED >> "/home/logs/log-primary.txt" 2>&1
+  primary $CONSENSUS_DISABLED
 elif [[ "$NODE_TYPE" = "worker" ]]; then
   echo "Bootstrapping new worker node with id $WORKER_ID"
 
@@ -41,8 +39,8 @@ elif [[ "$NODE_TYPE" = "worker" ]]; then
   --committee $COMMITTEE_PATH \
   --store "/validators/validator-$VALIDATOR_ID/db-worker-$WORKER_ID" \
   --parameters $PARAMETERS_PATH \
-  worker --id $WORKER_ID >> "/home/logs/log-worker-$WORKER_ID.txt" 2>&1
+  worker --id $WORKER_ID
 else
   echo "Unknown provided value for parameter: NODE_TYPE=$NODE_TYPE"
   exit 1
-fi
+fi

narwhal/Docker/scripts/gen.compose.py

@@ -154,7 +154,7 @@
   gateway:
     image: nginx:latest
     depends_on:
-      - loki
+      - read
     entrypoint:
       - sh
       - -euc