Correct animations #132
Merged
Correct animations #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Angular 17 animations to work correctly
Leave commented out code alone
NathanWalker
approved these changes
May 10, 2024
Contributor
|
Thank you @darklight365! |
Contributor
|
Published with @nativescript/[email protected] |
|
This fix now doesn't work because of c5f3a45. All I get is a null injector error for the injectable added in that commit:
I think that injectable should be made optional, as it is in the InjectableAnimationEngine implementation in the Angular code. |
|
Works now with 58d2254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Angular 17 animations to work correctly
Correct #125